Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 23496062: ARM: Fix simulator when using hard floating point ABI. (Closed)

Created:
7 years, 3 months ago by Rodolph Perfetta
Modified:
7 years, 3 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Visibility:
Public.

Description

ARM: Fix simulator when using hard floating point ABI. BUG=none TEST=make arm.release.check armfloatabi=hard R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -51 lines) Patch
M src/arm/codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/simulator-arm.h View 3 chunks +8 lines, -1 line 0 comments Download
M src/arm/simulator-arm.cc View 4 chunks +31 lines, -48 lines 0 comments Download
M test/cctest/test-code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Rodolph Perfetta
7 years, 3 months ago (2013-09-17 15:58:18 UTC) #1
Rodolph Perfetta
There were a number of failures due to incorrect parameter passing when using hard ABI.
7 years, 3 months ago (2013-09-17 16:08:10 UTC) #2
ulan
LGTM
7 years, 3 months ago (2013-09-18 08:37:23 UTC) #3
Rodolph Perfetta
7 years, 3 months ago (2013-09-18 15:13:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r16794 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698