Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: content/browser/vibration_message_filter.h

Issue 23496051: Make VibrationMessageFilter available to other platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated patch by review comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/vibration_message_filter.h
diff --git a/content/browser/vibration_message_filter.h b/content/browser/vibration_message_filter.h
new file mode 100644
index 0000000000000000000000000000000000000000..cdcb2558a38a7cb57c4cfea43acfb6504f0522ab
--- /dev/null
+++ b/content/browser/vibration_message_filter.h
@@ -0,0 +1,43 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_VIBRATION_MESSAGE_FILTER_H_
+#define CONTENT_BROWSER_VIBRATION_MESSAGE_FILTER_H_
+
+#include "content/public/browser/browser_message_filter.h"
+
+namespace content {
+
+class CONTENT_EXPORT VibrationMessageFilter
+ : public BrowserMessageFilter {
+ public:
+ VibrationMessageFilter();
Peter Beverloo 2013/09/13 16:14:12 If the Create() method is static, then the constru
+
+ // Create instance of VibrationMessageFilter.
Peter Beverloo 2013/09/13 16:14:12 "Create a platform-specific instance of the Vibrat
+ // Returns NULL if factory is not set (default implementation on android).
+ static VibrationMessageFilter* Create();
+
+ // Sets the VibrationMessageFilter factory function.
+ typedef VibrationMessageFilter* Factory();
Peter Beverloo 2013/09/13 16:14:12 I'm not too fussed about this. Like I asked earli
+ static void SetFactory(Factory* factory);
+
+ protected:
+ // Device should start vibrating for N milliseconds.
Peter Beverloo 2013/09/13 16:14:12 nit: I'd prefer it if this could be written as "vi
+ virtual void OnVibrate(int64 milliseconds) = 0;
+ // Cancels vibration of the device.
Peter Beverloo 2013/09/13 16:14:12 nit: empty line above here, perhaps?
+ virtual void OnCancelVibration() = 0;
+
+ virtual ~VibrationMessageFilter();
+
+ private:
+ // BrowserMessageFilter implementation.
+ virtual bool OnMessageReceived(const IPC::Message& message,
+ bool* message_was_ok) OVERRIDE;
+
+ static Factory* factory_;
+};
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_VIBRATION_MESSAGE_FILTER_H_

Powered by Google App Engine
This is Rietveld 408576698