content/renderer/renderer_webkitplatformsupport_impl.h - Issue 23496051: Make VibrationMessageFilter available to other platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_webkitplatformsupport_impl.h

Issue 23496051: Make VibrationMessageFilter available to other platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated patch by review comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/renderer_webkitplatformsupport_impl.h

diff --git a/content/renderer/renderer_webkitplatformsupport_impl.h b/content/renderer/renderer_webkitplatformsupport_impl.h

index 1ec2a6c89a1fc31d6949cf48f792b26b238f31ce..b04a8fba4904f4df283b5f75b333db5ca14f1ded 100644

--- a/content/renderer/renderer_webkitplatformsupport_impl.h

+++ b/content/renderer/renderer_webkitplatformsupport_impl.h

@@ -148,10 +148,8 @@ class CONTENT_EXPORT RendererWebKitPlatformSupportImpl

WebKit::WebStorageQuotaType,

WebKit::WebStorageQuotaCallbacks*) OVERRIDE;

-#if defined(OS_ANDROID)

virtual void vibrate(unsigned int milliseconds);

virtual void cancelVibration();

Peter Beverloo 2013/09/13 16:14:12 These should be annotated with OVERRIDE because th

-#endif // defined(OS_ANDROID)

// Disables the WebSandboxSupport implementation for testing.

// Tests that do not set up a full sandbox environment should call

« content/browser/vibration_message_filter.h ('K') | « content/content_browser.gypi ('k') | content/renderer/renderer_webkitplatformsupport_impl.cc » ('j') | no next file with comments »