Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 23496051: Make VibrationMessageFilter available to other platforms. (Closed)

Created:
7 years, 3 months ago by ostap
Modified:
7 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make VibrationMessageFilter available to other platforms. Adds VibrationProvider interface that simplifies adding vibration API handlers for other platforms and moves Android implementation into VibrationProviderAndroid. Also adds ContentBrowserClient::OverrideVibrationProvider() method that allows embedder application override handling of blink Vibration API. BUG=222504 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237101

Patch Set 1 #

Total comments: 5

Patch Set 2 : Updated patch by review comments. #

Total comments: 9

Patch Set 3 : Refactored to VibrationProvider/VibrationDispatcherHost by review comments and email discussion. #

Patch Set 4 : Rebased patch #

Total comments: 2

Patch Set 5 : Rebased and updated by review comments. #

Patch Set 6 : Patch rebased after r231091 #

Total comments: 17

Patch Set 7 : Patch rebased after 233513 and updated by review comments. #

Total comments: 8

Patch Set 8 : Fixed clang compile issues and updated by review comments. #

Total comments: 7

Patch Set 9 : Rebased and updated by review comments. #

Total comments: 4

Patch Set 10 : Updated by review comments #

Total comments: 2

Patch Set 11 : Rebased and added contact info for override APIs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -213 lines) Patch
M content/browser/android/browser_jni_registrar.cc View 1 2 3 4 5 6 7 8 3 chunks +2 lines, -2 lines 0 comments Download
D content/browser/android/vibration_message_filter.h View 1 chunk +0 lines, -34 lines 0 comments Download
D content/browser/android/vibration_message_filter.cc View 1 2 3 4 5 6 1 chunk +0 lines, -73 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +1 line, -6 lines 0 comments Download
A + content/browser/vibration/vibration_message_filter.h View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -8 lines 0 comments Download
A + content/browser/vibration/vibration_message_filter.cc View 1 2 3 4 5 6 7 8 9 2 chunks +21 lines, -25 lines 0 comments Download
A content/browser/vibration/vibration_provider_android.h View 1 2 3 4 5 6 1 chunk +30 lines, -0 lines 0 comments Download
A content/browser/vibration/vibration_provider_android.cc View 1 2 3 4 5 6 7 8 9 1 chunk +57 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +9 lines, -9 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 10 3 chunks +5 lines, -2 lines 0 comments Download
M content/content_jni.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
A content/port/browser/vibration_provider.h View 1 2 3 4 5 6 7 8 9 1 chunk +23 lines, -0 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/VibrationMessageFilter.java View 1 2 3 4 5 1 chunk +0 lines, -43 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content/browser/VibrationProvider.java View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +11 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 37 (0 generated)
ostap
7 years, 3 months ago (2013-09-11 23:00:43 UTC) #1
Avi (use Gerrit)
Link to a bug with BUG line. Please specify which reviewers you are requesting to ...
7 years, 3 months ago (2013-09-12 05:05:57 UTC) #2
ostap
On 2013/09/12 05:05:57, Avi wrote: > Please specify which reviewers you are requesting to review ...
7 years, 3 months ago (2013-09-12 16:14:30 UTC) #3
Peter Beverloo
+Michael who should also review this. I left some general comments. Could you please clarify ...
7 years, 3 months ago (2013-09-13 16:14:12 UTC) #4
ostap
Redesign it similar to LocationProvider.
7 years, 3 months ago (2013-09-18 15:44:01 UTC) #5
ostap
Rebased patch.
7 years, 2 months ago (2013-10-10 21:12:51 UTC) #6
Michael van Ouwerkerk
Please make sure this patch compiles. I ran some try bots, they look unhappy. Have ...
7 years, 2 months ago (2013-10-16 13:21:41 UTC) #7
ostap
On 2013/10/16 13:21:41, Michael van Ouwerkerk wrote: > Please make sure this patch compiles. I ...
7 years, 2 months ago (2013-10-16 15:17:00 UTC) #8
ostap
Patch rebased after r231091
7 years, 1 month ago (2013-11-06 00:28:06 UTC) #9
Michael van Ouwerkerk
Please add more detail to the patch description. Please also run the try bots after ...
7 years, 1 month ago (2013-11-08 14:41:05 UTC) #10
ostap
> Please add more detail to the patch description. Done > Please also run the ...
7 years, 1 month ago (2013-11-08 20:33:41 UTC) #11
Michael van Ouwerkerk
https://codereview.chromium.org/23496051/diff/137001/content/browser/vibration/vibration_message_filter.cc File content/browser/vibration/vibration_message_filter.cc (right): https://codereview.chromium.org/23496051/diff/137001/content/browser/vibration/vibration_message_filter.cc#newcode28 content/browser/vibration/vibration_message_filter.cc:28: if (!provider_) When using scoped_ptr then checks like this ...
7 years, 1 month ago (2013-11-11 12:11:19 UTC) #12
ostap
https://codereview.chromium.org/23496051/diff/137001/content/browser/vibration/vibration_message_filter.cc File content/browser/vibration/vibration_message_filter.cc (right): https://codereview.chromium.org/23496051/diff/137001/content/browser/vibration/vibration_message_filter.cc#newcode28 content/browser/vibration/vibration_message_filter.cc:28: if (!provider_) On 2013/11/11 12:11:20, Michael van Ouwerkerk wrote: ...
7 years, 1 month ago (2013-11-11 18:02:13 UTC) #13
Michael van Ouwerkerk
Thanks! lgtm
7 years, 1 month ago (2013-11-11 18:10:12 UTC) #14
ostap
Please, can somebody review changes in content folder? Thanks.
7 years, 1 month ago (2013-11-18 18:26:12 UTC) #15
Avi (use Gerrit)
When you first sent this CL out, you added a ton of reviewers but never ...
7 years, 1 month ago (2013-11-18 18:56:30 UTC) #16
Avi (use Gerrit)
On 2013/09/12 16:14:30, ostap wrote: > On 2013/09/12 05:05:57, Avi wrote: > > Please specify ...
7 years, 1 month ago (2013-11-18 18:59:04 UTC) #17
ostap
On 2013/11/18 18:59:04, Avi wrote: > On 2013/09/12 16:14:30, ostap wrote: > > On 2013/09/12 ...
7 years, 1 month ago (2013-11-18 20:01:22 UTC) #18
ostap
jochen@chromium.org, please review content/browser/renderer_host/render_process_host_impl.cc and content/renderer/* cdn@chromium.org, please review content/common/view_messages.h joi@chromium.org, please review content/port/browser/vibration_provider.h and ...
7 years, 1 month ago (2013-11-18 21:47:18 UTC) #19
Avi (use Gerrit)
https://codereview.chromium.org/23496051/diff/287001/content/public/browser/content_browser_client.h File content/public/browser/content_browser_client.h (right): https://codereview.chromium.org/23496051/diff/287001/content/public/browser/content_browser_client.h#newcode577 content/public/browser/content_browser_client.h:577: virtual VibrationProvider* OverrideVibrationProvider(); On 2013/11/18 21:47:18, ostap wrote: > ...
7 years, 1 month ago (2013-11-18 21:49:48 UTC) #20
Yaron
content/public/android lgtm
7 years, 1 month ago (2013-11-18 22:52:12 UTC) #21
Cris Neckar
IPC changes LGTM
7 years, 1 month ago (2013-11-18 22:58:07 UTC) #22
Jói
Like Avi, I would like to know whether there is already a use for this. ...
7 years, 1 month ago (2013-11-19 12:07:48 UTC) #23
jochen (gone - plz use gerrit)
I'm deferring to Avi, since he owns all of content/ anyway
7 years, 1 month ago (2013-11-19 13:19:15 UTC) #24
Avi (use Gerrit)
On 2013/11/19 12:07:48, Jói wrote: > Like Avi, I would like to know whether there ...
7 years, 1 month ago (2013-11-19 17:24:50 UTC) #25
ostap
On 2013/11/19 17:24:50, Avi wrote: > On 2013/11/19 12:07:48, Jói wrote: > > Like Avi, ...
7 years, 1 month ago (2013-11-19 18:07:07 UTC) #26
Avi (use Gerrit)
Ah, didn't know that. Carry on. LGTM once you fix minor formatting nits. https://codereview.chromium.org/23496051/diff/477001/content/port/browser/vibration_provider.h File ...
7 years, 1 month ago (2013-11-19 18:11:55 UTC) #27
ostap
On 2013/11/19 12:07:48, Jói wrote: > If this goes ahead, I think it would make ...
7 years, 1 month ago (2013-11-19 19:58:06 UTC) #28
ostap
https://codereview.chromium.org/23496051/diff/477001/content/port/browser/vibration_provider.h File content/port/browser/vibration_provider.h (right): https://codereview.chromium.org/23496051/diff/477001/content/port/browser/vibration_provider.h#newcode1 content/port/browser/vibration_provider.h:1: // Copyright (c) 2013 The Chromium Authors. All rights ...
7 years, 1 month ago (2013-11-19 19:58:32 UTC) #29
Avi (use Gerrit)
On 2013/11/19 12:07:48, Jói wrote: > Like Avi, I would like to know whether there ...
7 years ago (2013-11-22 15:36:34 UTC) #30
ostap
On 2013/11/22 15:36:34, Avi wrote: > On 2013/11/19 12:07:48, Jói wrote: > > If this ...
7 years ago (2013-11-22 15:56:02 UTC) #31
Avi (use Gerrit)
https://codereview.chromium.org/23496051/diff/607001/content/public/browser/content_browser_client.h File content/public/browser/content_browser_client.h (right): https://codereview.chromium.org/23496051/diff/607001/content/public/browser/content_browser_client.h#newcode576 content/public/browser/content_browser_client.h:576: // Return NULL to use the default one for ...
7 years ago (2013-11-22 16:08:48 UTC) #32
ostap
https://codereview.chromium.org/23496051/diff/607001/content/public/browser/content_browser_client.h File content/public/browser/content_browser_client.h (right): https://codereview.chromium.org/23496051/diff/607001/content/public/browser/content_browser_client.h#newcode576 content/public/browser/content_browser_client.h:576: // Return NULL to use the default one for ...
7 years ago (2013-11-22 17:24:18 UTC) #33
Avi (use Gerrit)
On 2013/11/22 17:24:18, ostap wrote: > https://codereview.chromium.org/23496051/diff/607001/content/public/browser/content_browser_client.h > File content/public/browser/content_browser_client.h (right): > > https://codereview.chromium.org/23496051/diff/607001/content/public/browser/content_browser_client.h#newcode576 > ...
7 years ago (2013-11-22 21:38:57 UTC) #34
Jói
LGTM
7 years ago (2013-11-25 11:04:54 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/23496051/707001
7 years ago (2013-11-25 16:12:24 UTC) #36
commit-bot: I haz the power
7 years ago (2013-11-25 18:12:57 UTC) #37
Message was sent while issue was closed.
Change committed as 237101

Powered by Google App Engine
This is Rietveld 408576698