Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 23496037: Turn a Dart String + String into a JavaScript String + String. (Closed)

Created:
7 years, 3 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Turn a Dart String + String into a JavaScript String + String. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=27281

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/optimize.dart View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + tests/compiler/dart2js/string_add_test.dart View 1 1 chunk +2 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/string_interpolation_test.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/utils/dummy_compiler_test.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tests/utils/recursive_import_test.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ngeoffray
7 years, 3 months ago (2013-09-06 08:39:39 UTC) #1
ahe
lgtm Can you test this?
7 years, 3 months ago (2013-09-06 10:13:44 UTC) #2
ngeoffray
On 2013/09/06 10:13:44, ahe wrote: > lgtm > > Can you test this? Yes, done ...
7 years, 3 months ago (2013-09-09 07:06:27 UTC) #3
ngeoffray
Committed patchset #4 manually as r27281 (presubmit successful).
7 years, 3 months ago (2013-09-09 09:37:22 UTC) #4
ahe
7 years, 3 months ago (2013-09-09 10:37:39 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698