Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2349593002: Wire WebFonts intervention v2 for ECT of 3G (Closed)

Created:
4 years, 3 months ago by tbansal1
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews-css, jam, dglazkov+blink, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, darktears, blink-reviews, darin-cc_chromium.org, kinuko+watch, blink-reviews-api_chromium.org, rwlbuis, bengr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wire WebFonts intervention v2 for ECT of 3G Wire Network Quality Estimator's (NQE) WebEffectiveConnectionType to RemoteFontFaceSource to make WebFonts intervention v2 effectively work when Effective Connection Type (ECT) is 3G. BUG=578029 Committed: https://crrev.com/22e15bab5fc56217572c1f6e09fc349751866fda Cr-Commit-Position: refs/heads/master@{#419817}

Patch Set 1 #

Total comments: 4

Patch Set 2 : toyoshim comments #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp View 1 2 2 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 30 (16 generated)
tbansal1
toyoshim: ptal at *. Thanks.
4 years, 3 months ago (2016-09-16 00:46:36 UTC) #5
tbansal1
toyoshim: ptal at *. Thanks.
4 years, 3 months ago (2016-09-16 00:46:38 UTC) #6
Takashi Toyoshima
Thank you for adding 3G! Looks almost good. Can you check the NOTREACHED case I ...
4 years, 3 months ago (2016-09-16 05:57:08 UTC) #9
Takashi Toyoshima
https://codereview.chromium.org/2349593002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2349593002/diff/1/chrome/app/generated_resources.grd#newcode15133 chrome/app/generated_resources.grd:15133: + <message name="IDS_FLAGS_ENABLE_WEBFONTS_INTERVENTION_V2_CHOICE_ENABLED_WITH_3G" desc="Text to indicate a experiment group ...
4 years, 3 months ago (2016-09-16 05:57:16 UTC) #10
tbansal1
toyoshim: ptal. thanks. https://codereview.chromium.org/2349593002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2349593002/diff/1/chrome/app/generated_resources.grd#newcode15133 chrome/app/generated_resources.grd:15133: + <message name="IDS_FLAGS_ENABLE_WEBFONTS_INTERVENTION_V2_CHOICE_ENABLED_WITH_3G" desc="Text to indicate ...
4 years, 3 months ago (2016-09-16 06:45:27 UTC) #11
Takashi Toyoshima
Thanks. LGTM.
4 years, 3 months ago (2016-09-16 09:20:25 UTC) #12
tbansal1
kinuko: ptal at content/ tkent: third_part/Webkit/ Thanks.
4 years, 3 months ago (2016-09-16 15:58:58 UTC) #14
tkent
third_part/Webkit/ lgtm
4 years, 3 months ago (2016-09-20 00:40:22 UTC) #16
Takashi Toyoshima
tbansal, since kinuko is taking a maternity leave now, you may want to find another ...
4 years, 3 months ago (2016-09-20 06:46:44 UTC) #17
kinuko
On 2016/09/20 06:46:44, toyoshim wrote: > tbansal, since kinuko is taking a maternity leave now, ...
4 years, 3 months ago (2016-09-20 14:01:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349593002/40001
4 years, 3 months ago (2016-09-20 18:14:37 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-20 18:20:44 UTC) #27
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/22e15bab5fc56217572c1f6e09fc349751866fda Cr-Commit-Position: refs/heads/master@{#419817}
4 years, 3 months ago (2016-09-20 18:23:30 UTC) #29
Takashi Toyoshima
4 years, 3 months ago (2016-09-21 06:31:44 UTC) #30
Message was sent while issue was closed.
Thanks, Kinuko-san :)

Powered by Google App Engine
This is Rietveld 408576698