Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 2349373003: [Chromecast] Disable net_unittests when running with sanitizers. (Closed)

Created:
4 years, 3 months ago by mbjorge
Modified:
4 years, 3 months ago
Reviewers:
slan
CC:
alokp+watch_chromium.org, chromium-reviews, halliwell+watch_chromium.org, lcwu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Disable net_unittests when running with sanitizers. When run with tsan and ubsan, the net_unittests take many hours to complete and waste build machine resources. The tests can be re-enabled once the source of the slowdown is found. BUG= internal b/31279943 Committed: https://crrev.com/47b1c9bb7b96eddd8924cb44164b76bf98749ae5 Cr-Commit-Position: refs/heads/master@{#419873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chromecast/BUILD.gn View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mbjorge
Re-did this CL with the new filter scope
4 years, 3 months ago (2016-09-20 18:29:41 UTC) #2
slan
lgtm
4 years, 3 months ago (2016-09-20 20:58:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349373003/1
4 years, 3 months ago (2016-09-20 21:20:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 22:23:37 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 22:25:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47b1c9bb7b96eddd8924cb44164b76bf98749ae5
Cr-Commit-Position: refs/heads/master@{#419873}

Powered by Google App Engine
This is Rietveld 408576698