Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Unified Diff: chromecast/BUILD.gn

Issue 2349373003: [Chromecast] Disable net_unittests when running with sanitizers. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/BUILD.gn
diff --git a/chromecast/BUILD.gn b/chromecast/BUILD.gn
index f7c815988842838b4af4da0cd98364e488122223..c2b75b28b998d6cc3a7d71d8c8547826d952104e 100644
--- a/chromecast/BUILD.gn
+++ b/chromecast/BUILD.gn
@@ -5,6 +5,7 @@
import("//build/buildflag_header.gni")
import("//build/config/features.gni")
import("//build/config/locales.gni")
+import("//build/config/sanitizers/sanitizers.gni")
import("//build/config/ui.gni")
import("//chromecast/build/tests/cast_test.gni")
import("//chromecast/chromecast.gni")
@@ -228,6 +229,15 @@ cast_test_group("cast_tests") {
}
}
filters += [ net_unittests_filter ]
+
+ # TODO(mbjorge): net_unittests do not complete when run with sanitizers,
+ # (in particular, TSAN and UBSAN), resulting in build machines getting stuck
+ # for many hours. Disable them for now, since these are getting run on
+ # Chromium bots anyway. (internal b/31279943)
+ if (using_sanitizer) {
+ tests -= [ "//net:net_unittests" ]
+ filters -= [ net_unittests_filter ]
+ }
}
# Creates the build and run lists for all test targets.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698