Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2349313002: [Merge-M53] arc: Fix Drag&Drop for PlayStore item from App List to Shelf. (Closed)

Created:
4 years, 3 months ago by khmel
Modified:
4 years, 3 months ago
Reviewers:
reviewer
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge-M53] arc: Fix Drag&Drop for PlayStore item from App List to Shelf. PlayStore is special app that actually represents 2 apps in Chrome. One is OptIn flow as native Platform App, second is Android Play Store app itself. For user we represent them as one app and do special mapping for Chrome shelf. This CL adds missing functionality for correct mapping. TEST=unit_tests TEST=Manually on device with all combination, app was pinned or not before, App (PlayStore and OptIn) was running or not. BUG=b/31556052 BUG=648285 TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2349263002 Cr-Commit-Position: refs/heads/master@{#419502} (cherry picked from commit ffdbe6cd0e06ea88251bdbfaa484b8b53c8fb1b2)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349313002/1
4 years, 3 months ago (2016-09-19 18:29:59 UTC) #2
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 18:35:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698