arc: Fix Drag&Drop for PlayStore item from App List to Shelf.

arc: Fix Drag&Drop for PlayStore item from App List to Shelf.

PlayStore is special app that actually represents 2 apps in Chrome.
One is OptIn flow as native Platform App, second is Android Play
Store app itself. For user we represent them as one app and do
special mapping for Chrome shelf. This CL adds missing functionality
for correct mapping.

TEST=unit_tests
TEST=Manually on device with all combination, app was pinned or
     not before, App (PlayStore and OptIn) was running or not.
BUG=b/31556052
BUG=648285
Committed: https://crrev.com/ffdbe6cd0e06ea88251bdbfaa484b8b53c8fb1b2
Cr-Commit-Position: refs/heads/master@{#419502}

[khmel, 2016-09-19 16:49:11]

khmel@chromium.org changed reviewers:
+ skuhne@chromium.org

[khmel, 2016-09-19 16:49:12]

Hi Stefan,

PTAL

https://codereview.chromium.org/2349263002/diff/1/chrome/browser/ui/ash/launc...
File
chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc
(right):

https://codereview.chromium.org/2349263002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc:37:
if (arc_app_prefs->IsRegistered(arc::kPlayStoreAppId) && arc_was_enabled) {
This fix UI glitch after making PlayStore as persistent app in AppList when user
clicks PlayStore shelf item to enable Arc. In this case spinning animation is
shown which is not expected for running OptIn flow.

[Mr4D (OOO till 08-26), 2016-09-19 17:30:19]

lgtm

https://codereview.chromium.org/2349263002/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc (right):

https://codereview.chromium.org/2349263002/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc:963: if
(GetPinnableForAppID(shelf_app_id, profile_) ==
The danger of having several app_id's. We might consider renaming one of them.
But since this seems to be urgent we can do that later...

[khmel, 2016-09-19 17:32:11]

On 2016/09/19 17:30:19, Mr4D wrote:
> lgtm
> 
>
https://codereview.chromium.org/2349263002/diff/1/chrome/browser/ui/ash/launc...
> File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
(right):
> 
>
https://codereview.chromium.org/2349263002/diff/1/chrome/browser/ui/ash/launc...
> chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc:963: if
> (GetPinnableForAppID(shelf_app_id, profile_) ==
> The danger of having several app_id's. We might consider renaming one of them.
> But since this seems to be urgent we can do that later...

Thanks for quick review!
I agree, current mapping impl is too heavy. I am thinking of refactoring a
little bit, but not in M53.

[khmel, 2016-09-19 17:32:21]

The CQ bit was checked by khmel@chromium.org

[commit-bot: I haz the power, 2016-09-19 17:32:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 18:00:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-19 18:01:56]

Description was changed from

==========
arc: Fix Drag&Drop for PlayStore item from App List to Shelf.

PlayStore is special app that actually represents 2 apps in Chrome.
One is OptIn flow as native Platform App, second is Android Play
Store app itself. For user we represent them as one app and do
special mapping for Chrome shelf. This CL adds missing functionality
for correct mapping.

TEST=unit_tests
TEST=Manually on device with all combination, app was pinned or
     not before, App (PlayStore and OptIn) was running or not.
BUG=b/31556052
BUG=648285
==========

to

==========
arc: Fix Drag&Drop for PlayStore item from App List to Shelf.

PlayStore is special app that actually represents 2 apps in Chrome.
One is OptIn flow as native Platform App, second is Android Play
Store app itself. For user we represent them as one app and do
special mapping for Chrome shelf. This CL adds missing functionality
for correct mapping.

TEST=unit_tests
TEST=Manually on device with all combination, app was pinned or
     not before, App (PlayStore and OptIn) was running or not.
BUG=b/31556052
BUG=648285

Committed: https://crrev.com/ffdbe6cd0e06ea88251bdbfaa484b8b53c8fb1b2
Cr-Commit-Position: refs/heads/master@{#419502}
==========

[commit-bot: I haz the power, 2016-09-19 18:01:57]

Patchset 1 (id:??) landed as
https://crrev.com/ffdbe6cd0e06ea88251bdbfaa484b8b53c8fb1b2
Cr-Commit-Position: refs/heads/master@{#419502}