Issue 23493019: remove most Isolate::Current asserts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23493019: remove most Isolate::Current asserts (Closed)

Created:
7 years, 3 months ago by dcarney

Modified:
7 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

remove most Isolate::Current asserts R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16552

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -27 lines)			Patch
M	src/builtins.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/compiler.h	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	src/debug.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/debug.cc	View	4 chunks	+0 lines, -4 lines	0 comments	Download
M	src/ic-inl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/isolate.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	src/mark-compact.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/objects-inl.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	src/regexp-macro-assembler.cc	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	src/regexp-stack.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/stub-cache.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/v8.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit https://codereview.chromium.org/23493019/diff/1/src/compiler.h File src/compiler.h (right): https://codereview.chromium.org/23493019/diff/1/src/compiler.h#newcode63 src/compiler.h:63: Isolate* isolate() { While we're ...

7 years, 3 months ago (2013-09-05 09:49:04 UTC) #2

dcarney

7 years, 3 months ago (2013-09-05 11:28:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16552 (presubmit successful).

Expand Messages | Collapse Messages