Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: src/builtins.cc

Issue 23493019: remove most Isolate::Current asserts (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/compiler.h » ('j') | src/compiler.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 // through the BuiltinArguments object args. 125 // through the BuiltinArguments object args.
126 126
127 #ifdef DEBUG 127 #ifdef DEBUG
128 128
129 #define BUILTIN(name) \ 129 #define BUILTIN(name) \
130 MUST_USE_RESULT static MaybeObject* Builtin_Impl_##name( \ 130 MUST_USE_RESULT static MaybeObject* Builtin_Impl_##name( \
131 name##ArgumentsType args, Isolate* isolate); \ 131 name##ArgumentsType args, Isolate* isolate); \
132 MUST_USE_RESULT static MaybeObject* Builtin_##name( \ 132 MUST_USE_RESULT static MaybeObject* Builtin_##name( \
133 int args_length, Object** args_object, Isolate* isolate) { \ 133 int args_length, Object** args_object, Isolate* isolate) { \
134 name##ArgumentsType args(args_length, args_object); \ 134 name##ArgumentsType args(args_length, args_object); \
135 ASSERT(isolate == Isolate::Current()); \
136 args.Verify(); \ 135 args.Verify(); \
137 return Builtin_Impl_##name(args, isolate); \ 136 return Builtin_Impl_##name(args, isolate); \
138 } \ 137 } \
139 MUST_USE_RESULT static MaybeObject* Builtin_Impl_##name( \ 138 MUST_USE_RESULT static MaybeObject* Builtin_Impl_##name( \
140 name##ArgumentsType args, Isolate* isolate) 139 name##ArgumentsType args, Isolate* isolate)
141 140
142 #else // For release mode. 141 #else // For release mode.
143 142
144 #define BUILTIN(name) \ 143 #define BUILTIN(name) \
145 static MaybeObject* Builtin_impl##name( \ 144 static MaybeObject* Builtin_impl##name( \
(...skipping 1710 matching lines...) Expand 10 before | Expand all | Expand 10 after
1856 return Handle<Code>(code_address); \ 1855 return Handle<Code>(code_address); \
1857 } 1856 }
1858 BUILTIN_LIST_C(DEFINE_BUILTIN_ACCESSOR_C) 1857 BUILTIN_LIST_C(DEFINE_BUILTIN_ACCESSOR_C)
1859 BUILTIN_LIST_A(DEFINE_BUILTIN_ACCESSOR_A) 1858 BUILTIN_LIST_A(DEFINE_BUILTIN_ACCESSOR_A)
1860 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A) 1859 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A)
1861 #undef DEFINE_BUILTIN_ACCESSOR_C 1860 #undef DEFINE_BUILTIN_ACCESSOR_C
1862 #undef DEFINE_BUILTIN_ACCESSOR_A 1861 #undef DEFINE_BUILTIN_ACCESSOR_A
1863 1862
1864 1863
1865 } } // namespace v8::internal 1864 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/compiler.h » ('j') | src/compiler.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698