Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2349153002: Fix bitfield enums to not trigger upcoming Clang warning (Closed)

Created:
4 years, 3 months ago by sashab
Modified:
4 years, 3 months ago
CC:
Reid Kleckner, Nico, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix bitfield enums to not trigger upcoming Clang warning Fix bitfield enums to not trigger upcoming Clang warning regarding non-unsigned enum bitfields producing non-portable code. For more details, see the patch here: https://reviews.llvm.org/D24289 BUG=648462 Committed: https://crrev.com/a81e00d533454a7179f8f954505a8f033e941a8a Cr-Commit-Position: refs/heads/master@{#39649}

Patch Set 1 #

Patch Set 2 : Small fix for GCC builds #

Patch Set 3 : Fixed formatting issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/base/safe_conversions_impl.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M src/globals.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/messages.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
sashab
4 years, 3 months ago (2016-09-20 00:00:55 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-20 09:39:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349153002/20001
4 years, 3 months ago (2016-09-23 01:04:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24793)
4 years, 3 months ago (2016-09-23 01:09:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349153002/40001
4 years, 3 months ago (2016-09-23 01:36:58 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-23 02:08:44 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/a81e00d533454a7179f8f954505a8f033e941a8a Cr-Commit-Position: refs/heads/master@{#39649}
4 years, 3 months ago (2016-09-23 02:08:58 UTC) #14
sashab
4 years, 3 months ago (2016-09-23 02:26:21 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2361013003/ by sashab@chromium.org.

The reason for reverting is: Causes warning in GCC..

Powered by Google App Engine
This is Rietveld 408576698