src/globals.h - Issue 2349153002: Fix bitfield enums to not trigger upcoming Clang warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/globals.h

Issue 2349153002: Fix bitfield enums to not trigger upcoming Clang warning (Closed)

Patch Set: Fixed formatting issues Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/globals.h

diff --git a/src/globals.h b/src/globals.h

index 3abbc6b6f9fd7bf8407d7623bc147e8a183f45c4..81888e17bdb57e3e14588b5b5bfc7d31593b8224 100644

--- a/src/globals.h

+++ b/src/globals.h

@@ -1058,8 +1058,7 @@ enum InitializationFlag : uint8_t { kNeedsInitialization, kCreatedInitialized };

enum MaybeAssignedFlag : uint8_t { kNotAssigned, kMaybeAssigned };

// Serialized in PreparseData, so numeric values should not be changed.

-enum ParseErrorType { kSyntaxError = 0, kReferenceError = 1 };

+enum ParseErrorType : uint8_t { kSyntaxError = 0, kReferenceError = 1 };

enum MinusZeroMode {

TREAT_MINUS_ZERO_AS_ZERO,

« no previous file with comments | « src/base/safe_conversions_impl.h ('k') | src/messages.h » ('j') | no next file with comments »