Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: net/cert/internal/cert_error_params.h

Issue 2349103002: Include the RSA key modulus size in error message when it is too small. (Closed)
Patch Set: address mattm's comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cert/internal/cert_error_params.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/cert_error_params.h
diff --git a/net/cert/internal/cert_error_params.h b/net/cert/internal/cert_error_params.h
index 5201cdaa12080b058e0dbee646fdba891d257c8b..a57c24781ee8a94edabda8f6ad743c82f68b6d6a 100644
--- a/net/cert/internal/cert_error_params.h
+++ b/net/cert/internal/cert_error_params.h
@@ -43,11 +43,11 @@ class NET_EXPORT CertErrorParams {
// so error consumers can access their data directly? (Without having to go
// through the generic virtuals).
-// Creates a parameter object that holds a copy of |der1|, and names it |name1|
+// Creates a parameter object that holds a copy of |der|, and names it |name|
// in debug string outputs.
NET_EXPORT std::unique_ptr<CertErrorParams> CreateCertErrorParams1Der(
- const char* name1,
- const der::Input& der1);
+ const char* name,
+ const der::Input& der);
// Same as CreateCertErrorParams1Der() but has a second DER blob.
NET_EXPORT std::unique_ptr<CertErrorParams> CreateCertErrorParams2Der(
@@ -58,10 +58,17 @@ NET_EXPORT std::unique_ptr<CertErrorParams> CreateCertErrorParams2Der(
// Creates a parameter object that holds a single size_t value. |name| is used
// when pretty-printing the parameters.
-NET_EXPORT std::unique_ptr<CertErrorParams> CreateCertErrorParamsSizeT(
+NET_EXPORT std::unique_ptr<CertErrorParams> CreateCertErrorParams1SizeT(
const char* name,
size_t value);
+// Same as CreateCertErrorParams1SizeT() but has a second size_t.
+NET_EXPORT std::unique_ptr<CertErrorParams> CreateCertErrorParams2SizeT(
+ const char* name1,
+ size_t value1,
+ const char* name2,
+ size_t value2);
+
} // namespace net
#endif // NET_CERT_INTERNAL_CERT_ERROR_PARAMS_H_
« no previous file with comments | « no previous file | net/cert/internal/cert_error_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698