Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2349083002: Update Crashpad to 23d31c4fea61962e156f992889c6b041ad757d12 (Closed)

Created:
4 years, 3 months ago by scottmg
Modified:
4 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Crashpad to 23d31c4fea61962e156f992889c6b041ad757d12 866e60749c1f Add >nul to editbin command to suppress \n in build output 357c7c7b7bbf win: Add some explanation of .com/.exe for crashpad_handler c6f88d164e44 Have MinidumpMemoryListWriter deal directly in SnapshotMinidumpMemoryWriters 5f42313ed5ce Test first integration of UMA plumbing afc177ee2100 Pull metrics instrumentation out to central file 0c290220902d Update mini_chromium to 7800285e83df 27aeb2c9dacb Upstream Chromium UMA integration 23d31c4fea61 Fix Mac build after 27aeb2c9 Manually update util/BUILD.gn in Chromium tree. R=mark@chromium.org BUG=crashpad:100 Committed: https://crrev.com/d2daaf8c994e6949695a876dc164221e15d2bdc7 Cr-Commit-Position: refs/heads/master@{#419380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -199 lines) Patch
M build/secondary/third_party/crashpad/crashpad/util/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/crashpad/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/client/crash_report_database_mac.mm View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/client/crash_report_database_win.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/client/crashpad_client_win_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/crashpad/crashpad/handler/crashpad_handler.ad View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/handler/handler.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/handler/win/crashy_test_program.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_memory_writer.h View 7 chunks +27 lines, -47 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_memory_writer.cc View 8 chunks +38 lines, -76 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_thread_writer.h View 6 chunks +9 lines, -9 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_thread_writer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_memory_writer_test_util.h View 1 chunk +4 lines, -15 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/test/minidump_memory_writer_test_util.cc View 1 chunk +4 lines, -37 lines 0 comments Download
M third_party/crashpad/crashpad/tools/mac/run_with_crashpad.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/file/file_io.h View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/file/file_io_posix.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/file/file_io_test.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/file/file_io_win.cc View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/misc/metrics.h View 1 chunk +41 lines, -0 lines 0 comments Download
A + third_party/crashpad/crashpad/util/misc/metrics.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M third_party/crashpad/crashpad/util/util.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
scottmg
4 years, 3 months ago (2016-09-17 00:16:14 UTC) #7
Mark Mentovai
LGTM
4 years, 3 months ago (2016-09-17 12:42:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349083002/20001
4 years, 3 months ago (2016-09-17 15:50:05 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-17 19:44:59 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-17 19:48:26 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2daaf8c994e6949695a876dc164221e15d2bdc7
Cr-Commit-Position: refs/heads/master@{#419380}

Powered by Google App Engine
This is Rietveld 408576698