Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: third_party/crashpad/crashpad/handler/crashpad_handler.ad

Issue 2349083002: Update Crashpad to 23d31c4fea61962e156f992889c6b041ad757d12 (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/handler/crashpad_handler.ad
diff --git a/third_party/crashpad/crashpad/handler/crashpad_handler.ad b/third_party/crashpad/crashpad/handler/crashpad_handler.ad
index 4145773472db12ae44b0196b8569320a8ad34a34..06f625635cf739f799a2cb814ae3536ee4d2ff20 100644
--- a/third_party/crashpad/crashpad/handler/crashpad_handler.ad
+++ b/third_party/crashpad/crashpad/handler/crashpad_handler.ad
@@ -60,6 +60,16 @@ well as the client’s process handle for the client to exit cleanly without
crashing. When a server started via the *--handshake-handle* mechanism loses all
of its clients, it exits after allowing any upload in progress to complete.
+On Windows, this executable is built by default as a Windows GUI app, so no
+console will appear in normal usage. This is the version that will typically be
+used. A second copy is also made with a +.com+ extension, rather than +.exe+. In
+this second copy, the PE header is modified to indicate that it's a console app.
+This is useful because the +.com+ is found in the path before the +.exe+, so
+when run normally from a shell using only the basename (without an explicit
++.com+ or +.exe+ extension), the +.com+ console version will be chosen, and so
+stdio will be hooked up as expected to the parent console so that logging output
+will be visible.
+
It is not normally appropriate to invoke this program directly. Usually, it will
be invoked by a Crashpad client using the Crashpad client library, or started by
another system service. On OS X, arbitrary programs may be run with a Crashpad
« no previous file with comments | « third_party/crashpad/crashpad/client/crashpad_client_win_test.cc ('k') | third_party/crashpad/crashpad/handler/handler.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698