Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1414)

Unified Diff: blimp/client/core/settings/BUILD.gn

Issue 2349073002: Blimp Settings framework on the c++ side (Closed)
Patch Set: nits and sync to head Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/core/context/dummy_blimp_client_context.cc ('k') | blimp/client/core/settings/settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/core/settings/BUILD.gn
diff --git a/blimp/client/core/settings/BUILD.gn b/blimp/client/core/settings/BUILD.gn
index 39801cd928cc25ab55cc7761f9c14caa4912a12c..ad1e6f239166214e8f201b110743aa51af4d48b7 100644
--- a/blimp/client/core/settings/BUILD.gn
+++ b/blimp/client/core/settings/BUILD.gn
@@ -15,12 +15,19 @@ source_set("settings") {
sources = [
"blimp_settings_delegate.h",
+ "settings.cc",
+ "settings.h",
"settings_feature.cc",
"settings_feature.h",
+ "settings_observer.h",
+ "settings_prefs.cc",
+ "settings_prefs.h",
]
deps = [
+ "//blimp/client/core/switches",
"//blimp/common",
+ "//components/prefs",
"//net",
]
@@ -43,6 +50,25 @@ source_set("settings") {
}
}
+source_set("unit_tests") {
+ visibility = [ "//blimp/client/core:unit_tests" ]
+
+ testonly = true
+
+ sources = [
+ "settings_unittest.cc",
+ ]
+
+ deps = [
+ ":settings",
+ "//base",
+ "//blimp/client/core/switches:switches",
+ "//components/prefs:test_support",
+ "//testing/gmock",
+ "//testing/gtest",
+ ]
+}
+
if (is_android) {
android_library("settings_java") {
visibility = [
« no previous file with comments | « blimp/client/core/context/dummy_blimp_client_context.cc ('k') | blimp/client/core/settings/settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698