Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5194)

Unified Diff: blimp/client/core/context/dummy_blimp_client_context.cc

Issue 2349073002: Blimp Settings framework on the c++ side (Closed)
Patch Set: nits and sync to head Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/context/dummy_blimp_client_context.cc
diff --git a/blimp/client/core/context/dummy_blimp_client_context.cc b/blimp/client/core/context/dummy_blimp_client_context.cc
index 9bebbb8570f54e7fd3487592271ad6d4a61c1d31..892678f231045edce73648ddc69ae7043f05de78 100644
--- a/blimp/client/core/context/dummy_blimp_client_context.cc
+++ b/blimp/client/core/context/dummy_blimp_client_context.cc
@@ -25,7 +25,8 @@ namespace client {
BlimpClientContext* BlimpClientContext::Create(
scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner,
scoped_refptr<base::SingleThreadTaskRunner> file_thread_task_runner,
- std::unique_ptr<CompositorDependencies> compositor_dependencies) {
+ std::unique_ptr<CompositorDependencies> compositor_dependencies,
+ PrefService* local_state) {
#if defined(OS_ANDROID)
return new DummyBlimpClientContextAndroid();
#else
@@ -33,6 +34,20 @@ BlimpClientContext* BlimpClientContext::Create(
#endif // defined(OS_ANDROID)
}
+// This function is declared in //blimp/client/public/blimp_client_context.h,
+// and either this function or the one in
+// //blimp/client/core/blimp_client_context_impl.cc should be linked in to
+// any binary using BlimpClientContext::RegisterPrefs.
+// static
+void BlimpClientContext::RegisterPrefs(PrefRegistrySimple* registry) {}
+
+// This function is declared in //blimp/client/public/blimp_client_context.h,
+// and either this function or the one in
+// //blimp/client/core/blimp_client_context_impl.cc should be linked in to
+// any binary using BlimpClientContext::ApplyBlimpSwitches.
+// static
+void BlimpClientContext::ApplyBlimpSwitches(CommandLinePrefStore* store) {}
+
DummyBlimpClientContext::DummyBlimpClientContext() : BlimpClientContext() {
UMA_HISTOGRAM_BOOLEAN("Blimp.Supported", false);
}
« no previous file with comments | « blimp/client/core/context/blimp_client_context_impl_unittest.cc ('k') | blimp/client/core/settings/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698