Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: blimp/client/core/settings/BUILD.gn

Issue 2349073002: Blimp Settings framework on the c++ side (Closed)
Patch Set: Remove OnRecordWholeDocumentChanged from SettingsObserver and SettingsFeature Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/settings/BUILD.gn
diff --git a/blimp/client/core/settings/BUILD.gn b/blimp/client/core/settings/BUILD.gn
index 3f6cff6412ad24a6133148386b22ef085790aad6..95ece467c4961a03dc02c8da4c048b8d6daba6e6 100644
--- a/blimp/client/core/settings/BUILD.gn
+++ b/blimp/client/core/settings/BUILD.gn
@@ -12,12 +12,19 @@ source_set("settings") {
sources = [
"blimp_settings_delegate.h",
+ "settings.cc",
+ "settings.h",
"settings_feature.cc",
"settings_feature.h",
+ "settings_observer.h",
+ "settings_prefs.cc",
+ "settings_prefs.h",
]
deps = [
+ "//blimp/client/core/switches",
"//blimp/common",
+ "//components/prefs",
"//net",
]
@@ -40,6 +47,24 @@ source_set("settings") {
}
}
+source_set("unit_tests") {
+ visibility = [ "//blimp/client/core:unit_tests" ]
+
+ testonly = true
+
+ sources = [
+ "settings_unittest.cc",
+ ]
+
+ deps = [
+ ":settings",
+ "//base",
+ "//components/prefs:test_support",
+ "//testing/gmock",
+ "//testing/gtest",
+ ]
+}
+
if (is_android) {
android_library("settings_java") {
visibility = [ "//blimp/client/*" ]

Powered by Google App Engine
This is Rietveld 408576698