Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: blimp/client/core/settings/BUILD.gn

Issue 2349073002: Blimp Settings framework on the c++ side (Closed)
Patch Set: Remove OnRecordWholeDocumentChanged from SettingsObserver and SettingsFeature Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 } 8 }
9 9
10 source_set("settings") { 10 source_set("settings") {
11 visibility = [ "//blimp/client/*" ] 11 visibility = [ "//blimp/client/*" ]
12 12
13 sources = [ 13 sources = [
14 "blimp_settings_delegate.h", 14 "blimp_settings_delegate.h",
15 "settings.cc",
16 "settings.h",
15 "settings_feature.cc", 17 "settings_feature.cc",
16 "settings_feature.h", 18 "settings_feature.h",
19 "settings_observer.h",
20 "settings_prefs.cc",
21 "settings_prefs.h",
17 ] 22 ]
18 23
19 deps = [ 24 deps = [
25 "//blimp/client/core/switches",
20 "//blimp/common", 26 "//blimp/common",
27 "//components/prefs",
21 "//net", 28 "//net",
22 ] 29 ]
23 30
24 public_deps = [ 31 public_deps = [
25 "//base", 32 "//base",
26 "//blimp/net", 33 "//blimp/net",
27 ] 34 ]
28 35
29 if (is_android) { 36 if (is_android) {
30 sources += [ 37 sources += [
31 "android/blimp_settings_android.cc", 38 "android/blimp_settings_android.cc",
32 "android/blimp_settings_android.h", 39 "android/blimp_settings_android.h",
33 ] 40 ]
34 41
35 deps += [ 42 deps += [
36 ":settings_jni_headers", 43 ":settings_jni_headers",
37 "//blimp/client/core/session", 44 "//blimp/client/core/session",
38 "//blimp/common", 45 "//blimp/common",
39 ] 46 ]
40 } 47 }
41 } 48 }
42 49
50 source_set("unit_tests") {
51 visibility = [ "//blimp/client/core:unit_tests" ]
52
53 testonly = true
54
55 sources = [
56 "settings_unittest.cc",
57 ]
58
59 deps = [
60 ":settings",
61 "//base",
62 "//components/prefs:test_support",
63 "//testing/gmock",
64 "//testing/gtest",
65 ]
66 }
67
43 if (is_android) { 68 if (is_android) {
44 android_library("settings_java") { 69 android_library("settings_java") {
45 visibility = [ "//blimp/client/*" ] 70 visibility = [ "//blimp/client/*" ]
46 71
47 java_files = [ 72 java_files = [
48 "android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.j ava", 73 "android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.j ava",
49 "android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDelegat e.java", 74 "android/java/src/org/chromium/blimp/core/settings/BlimpPreferencesDelegat e.java",
50 ] 75 ]
51 76
52 # TODO(xingliu): Clean resources files in the future. http://crbug.com/63068 7. 77 # TODO(xingliu): Clean resources files in the future. http://crbug.com/63068 7.
(...skipping 11 matching lines...) Expand all
64 generate_jni("settings_jni_headers") { 89 generate_jni("settings_jni_headers") {
65 visibility = [ ":*" ] 90 visibility = [ ":*" ]
66 91
67 sources = [ 92 sources = [
68 "android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.j ava", 93 "android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.j ava",
69 ] 94 ]
70 95
71 jni_package = "blimp/client/core/settings" 96 jni_package = "blimp/client/core/settings"
72 } 97 }
73 } 98 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698