Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2349023003: [Devtools] Fixed not showing remoteaddress in network log (Closed)

Created:
4 years, 3 months ago by allada
Modified:
4 years, 3 months ago
Reviewers:
kozy, lushnikov
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed not showing remoteaddress in network log Fixed bug where network log view was not showing certain columns (like remoteaddress). R=lushnikov BUG=623900, 647439 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2330613002 Cr-Commit-Position: refs/heads/master@{#418141} (cherry picked from commit a5326e37b41001c675d27d0c160daedcbc1b1d97)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible-expected.txt View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349023003/1
4 years, 3 months ago (2016-09-17 01:06:34 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-17 01:06:36 UTC) #4
kozy
lgtm
4 years, 3 months ago (2016-09-17 01:07:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349023003/1
4 years, 3 months ago (2016-09-17 01:07:41 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 3 months ago (2016-09-17 01:07:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2349023003/1
4 years, 3 months ago (2016-09-17 01:08:50 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-17 01:11:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698