Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2330613002: [Devtools] Fixed not showing remoteaddress in network log (Closed)

Created:
4 years, 3 months ago by allada
Modified:
4 years, 3 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed not showing remoteaddress in network log Fixed bug where network log view was not showing certain columns (like remoteaddress). R=lushnikov BUG=623900, 647439 Committed: https://crrev.com/a5326e37b41001c675d27d0c160daedcbc1b1d97 Cr-Commit-Position: refs/heads/master@{#418141}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible-expected.txt View 1 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
allada
PTL
4 years, 3 months ago (2016-09-09 23:38:46 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2330613002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html File third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html (right): https://codereview.chromium.org/2330613002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html#newcode13 third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html:13: var columnsToTest = ["name", "method", "status", "protocol", "scheme", ...
4 years, 3 months ago (2016-09-09 23:47:57 UTC) #3
allada
https://codereview.chromium.org/2330613002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html File third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html (right): https://codereview.chromium.org/2330613002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html#newcode13 third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html:13: var columnsToTest = ["name", "method", "status", "protocol", "scheme", "domain", ...
4 years, 3 months ago (2016-09-09 23:50:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330613002/1
4 years, 3 months ago (2016-09-09 23:51:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/290927)
4 years, 3 months ago (2016-09-10 01:34:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330613002/20001
4 years, 3 months ago (2016-09-13 00:21:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-13 02:10:36 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 02:12:30 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a5326e37b41001c675d27d0c160daedcbc1b1d97
Cr-Commit-Position: refs/heads/master@{#418141}

Powered by Google App Engine
This is Rietveld 408576698