[Devtools] Fixed not showing remoteaddress in network log

[Devtools] Fixed not showing remoteaddress in network log

Fixed bug where network log view was not showing certain
columns (like remoteaddress).

R=lushnikov
BUG=623900, 647439
Committed: https://crrev.com/a5326e37b41001c675d27d0c160daedcbc1b1d97
Cr-Commit-Position: refs/heads/master@{#418141}

[allada, 2016-09-09 23:38:45]

allada@chromium.org changed reviewers:
+ dgozman@chromium.org

[allada, 2016-09-09 23:38:46]

PTL

[dgozman, 2016-09-09 23:47:57]

lgtm

https://codereview.chromium.org/2330613002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html
(right):

https://codereview.chromium.org/2330613002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html:13:
var columnsToTest = ["name", "method", "status", "protocol", "scheme", "domain",
"remoteaddress", "type", "initiator", "cookies", "setcookies", "size",
"priority", "cache-control", "connection", "content-encoding", "content-length",
"vary"];
Can we get these from WebInspector.NetworkLogViewColumns._defaultColumns, so
that you don't have to remember to change the test when changing the log view?

[allada, 2016-09-09 23:50:48]

https://codereview.chromium.org/2330613002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html
(right):

https://codereview.chromium.org/2330613002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html:13:
var columnsToTest = ["name", "method", "status", "protocol", "scheme", "domain",
"remoteaddress", "type", "initiator", "cookies", "setcookies", "size",
"priority", "cache-control", "connection", "content-encoding", "content-length",
"vary"];
On 2016/09/09 23:47:57, dgozman wrote:
> Can we get these from WebInspector.NetworkLogViewColumns._defaultColumns, so
> that you don't have to remember to change the test when changing the log view?

Opted out of this because of potential flakiness and did not black list ones
because we will likely be adding more defaults in the future that will require
too much blacklisting.

[allada, 2016-09-09 23:50:53]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2016-09-09 23:51:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 01:34:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 01:34:49]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[allada, 2016-09-13 00:21:16]

The CQ bit was checked by allada@chromium.org

[allada, 2016-09-13 00:21:16]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2330613002/#ps20001
(title: "Changes")

[commit-bot: I haz the power, 2016-09-13 00:21:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 02:10:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-13 02:12:29]

Description was changed from

==========
[Devtools] Fixed not showing remoteaddress in network log

Fixed bug where network log view was not showing certain
columns (like remoteaddress).

R=lushnikov
BUG=623900
==========

to

==========
[Devtools] Fixed not showing remoteaddress in network log

Fixed bug where network log view was not showing certain
columns (like remoteaddress).

R=lushnikov
BUG=623900

Committed: https://crrev.com/a5326e37b41001c675d27d0c160daedcbc1b1d97
Cr-Commit-Position: refs/heads/master@{#418141}
==========

[commit-bot: I haz the power, 2016-09-13 02:12:30]

Patchset 2 (id:??) landed as
https://crrev.com/a5326e37b41001c675d27d0c160daedcbc1b1d97
Cr-Commit-Position: refs/heads/master@{#418141}

[allada, 2016-09-15 21:49:54]

Description was changed from

==========
[Devtools] Fixed not showing remoteaddress in network log

Fixed bug where network log view was not showing certain
columns (like remoteaddress).

R=lushnikov
BUG=623900

Committed: https://crrev.com/a5326e37b41001c675d27d0c160daedcbc1b1d97
Cr-Commit-Position: refs/heads/master@{#418141}
==========

to

==========
[Devtools] Fixed not showing remoteaddress in network log

Fixed bug where network log view was not showing certain
columns (like remoteaddress).

R=lushnikov
BUG=623900,647439

Committed: https://crrev.com/a5326e37b41001c675d27d0c160daedcbc1b1d97
Cr-Commit-Position: refs/heads/master@{#418141}
==========