API changes to make TypedefMirror a direct descendant of TypeMirror.

API changes to make TypedefMirror a direct descendant of TypeMirror.

BUG=http://dartbug.com/11616

[gbracha, 2013-08-31 06:14:12]

lgtm

[rmacnak, 2013-09-05 18:55:09]

Ping

[ahe, 2013-09-05 20:48:25]

LGTM.

I added some extra comments to the CL, but that is to open the discussion, not
anything I think you need to address in this CL.

https://codereview.chromium.org/23490019/diff/1/sdk/lib/mirrors/mirrors.dart
File sdk/lib/mirrors/mirrors.dart (right):

https://codereview.chromium.org/23490019/diff/1/sdk/lib/mirrors/mirrors.dart#...
sdk/lib/mirrors/mirrors.dart:649: Map<Symbol, TypeMirror> get types;
I assume this goes away again after the "mirrors overhaul" CL.

PS: This is where I got stuck the first time I looked at this CL ;-)

https://codereview.chromium.org/23490019/diff/1/sdk/lib/mirrors/mirrors.dart#...
sdk/lib/mirrors/mirrors.dart:908: abstract class FunctionTypeMirror implements
ClassMirror {
This is still a bit weird I think.

https://codereview.chromium.org/23490019/diff/1/sdk/lib/mirrors/mirrors.dart#...
sdk/lib/mirrors/mirrors.dart:922: MethodMirror get callMethod;
This method makes little sense to me. Do you know what it is for?

[rmacnak, 2013-09-05 22:43:29]

https://chromiumcodereview.appspot.com/23490019/diff/1/sdk/lib/mirrors/mirror...
File sdk/lib/mirrors/mirrors.dart (right):

https://chromiumcodereview.appspot.com/23490019/diff/1/sdk/lib/mirrors/mirror...
sdk/lib/mirrors/mirrors.dart:649: Map<Symbol, TypeMirror> get types;
On 2013/09/05 20:48:26, ahe wrote:
> I assume this goes away again after the "mirrors overhaul" CL.
> 
> PS: This is where I got stuck the first time I looked at this CL ;-)

Right, this would be covered by LibraryMirror.declarations.

https://chromiumcodereview.appspot.com/23490019/diff/1/sdk/lib/mirrors/mirror...
sdk/lib/mirrors/mirrors.dart:922: MethodMirror get callMethod;
On 2013/09/05 20:48:26, ahe wrote:
> This method makes little sense to me. Do you know what it is for?

The methods of closures are special. reflect(()=>null).type.methods[#call]
doesn't work. I think there are plans to specify that function application is
just sugar for invoking call, then this will be unnecessary.