Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2348993002: Don't include LayoutObject.h from FrameView.h (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews-html_chromium.org, dshwang, eae+blinkwatch, shans, apavlov+blink_chromium.org, kinuko+watch, rwlbuis, blink-reviews-css, szager+layoutwatch_chromium.org, dglazkov+blink, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, Eric Willigers, kenneth.christiansen, rjwright, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, darktears, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't include LayoutObject.h from FrameView.h This reduces the LayoutObject.h dependency by about 50 compilation units. Needed to move data of DepthOrderedLayoutObjectList into a forward-declared struct, since HashSet members need their T defined, even if it's a pointer. This due to oilpan. See https://codereview.chromium.org/1999343002 for details. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/ed98e051cdbac8bec50e76ff68394fb39404f5eb Cr-Commit-Position: refs/heads/master@{#419728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -28 lines) Patch
M third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventDispatcher.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/TouchEvent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrameTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/DepthOrderedLayoutObjectList.h View 2 chunks +9 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/DepthOrderedLayoutObjectList.cpp View 2 chunks +49 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityController.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizerTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/PageAnimator.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/SnapCoordinatorTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidatorTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
mstensho (USE GERRIT)
4 years, 3 months ago (2016-09-16 20:21:24 UTC) #6
eae
RS LGTM
4 years, 3 months ago (2016-09-16 20:24:22 UTC) #7
pdr.
Could Opera setup a bot to help track these sorts of issues for non-goma'ers, such ...
4 years, 3 months ago (2016-09-16 20:38:27 UTC) #8
mstensho (USE GERRIT)
Adding a bunch of reviewers for Source/web/ (since the one I initially picked went OOO) ...
4 years, 3 months ago (2016-09-20 07:17:16 UTC) #13
haraken
LGTM
4 years, 3 months ago (2016-09-20 07:29:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348993002/1
4 years, 3 months ago (2016-09-20 10:00:17 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 12:29:26 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 12:32:01 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed98e051cdbac8bec50e76ff68394fb39404f5eb
Cr-Commit-Position: refs/heads/master@{#419728}

Powered by Google App Engine
This is Rietveld 408576698