Port storage manager to MD settings.

chromeos/chromeos_switches.cc

Index: chromeos/chromeos_switches.cc
diff --git a/chromeos/chromeos_switches.cc b/chromeos/chromeos_switches.cc
index cfe7113c68e8d79fa40ee8d6fc753f653c65ec39..3843d0dc3195c99c197822b8de579139415cfb04 100644
--- a/chromeos/chromeos_switches.cc
+++ b/chromeos/chromeos_switches.cc
@@ -161,6 +161,9 @@ const char kDisableHIDDetectionOnOOBE[] = "disable-hid-detection-on-oobe";
 // Avoid doing expensive animations upon login.
 const char kDisableLoginAnimations[] = "disable-login-animations";
 
+// Disables storage manager in MD Settings.
+const char kDisableMdStorageManager[] = "disable-md-storage-manager";
+
 // Disables mtp write support.
 const char kDisableMtpWriteSupport[] = "disable-mtp-write-support";
 
@@ -253,6 +256,9 @@ const char kDisableMdOobe[] = "disable-md-oobe";
 const char kEnableNetworkPortalNotification[] =
     "enable-network-portal-notification";
 
+// Enables storage manager in MD Settings.
+const char kEnableMdStorageManager[] = "enable-md-storage-manager";

[michaelpg, 2016/10/01 01:41:05]

shouldn't we only have one of these flags?

[fukino, 2016/10/03 18:40:42]

I used ENABLE_DISABLE_VALUE_TYPE to have a default value so that we can easily
change the default setting of MD settings manager back and forth.

Is it better to use single value (e.g. enable-md-storage-manager), and when we
enable it by default we should delete the flag?

[michaelpg, 2016/10/03 23:44:44]

Generally yes, is it important that we be able to disable this after shipping
it?

[fukino, 2016/10/04 09:03:53]

Got it. I updated the CL to use a single value flag to enable md storage
manager.

+
 // Enables suggestions while typing on a physical keyboard.
 const char kEnablePhysicalKeyboardAutocorrect[] =
     "enable-physical-keyboard-autocorrect";