Port storage manager to MD settings.

chromeos/chromeos_switches.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/chromeos_switches.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
@@ skipping 143 matching lines @@
 // Disables GAIA services such as enrollment and OAuth session restore. Used by
 // 'fake' telemetry login.
 const char kDisableGaiaServices[] = "disable-gaia-services";
 
 // Disables HID-detection OOBE screen.
 const char kDisableHIDDetectionOnOOBE[] = "disable-hid-detection-on-oobe";
 
 // Avoid doing expensive animations upon login.
 const char kDisableLoginAnimations[] = "disable-login-animations";
 
+// Disables storage manager in MD Settings.
+const char kDisableMdStorageManager[] = "disable-md-storage-manager";
+
 // Disables mtp write support.
 const char kDisableMtpWriteSupport[] = "disable-mtp-write-support";
 
 // Disables the multiple display layout UI.
 const char kDisableMultiDisplayLayout[] = "disable-multi-display-layout";
 
 // Disables notifications about captive portals in session.
 const char kDisableNetworkPortalNotification[] =
     "disable-network-portal-notification";
 
@@ skipping 72 matching lines @@
 // rather than the kiosk app mode.
 const char kEnableKioskMode[] = "enable-kiosk-mode";
 
 // Disables material design OOBE UI.
 const char kDisableMdOobe[] = "disable-md-oobe";
 
 // Enables notifications about captive portals in session.
 const char kEnableNetworkPortalNotification[] =
     "enable-network-portal-notification";
 
+// Enables storage manager in MD Settings.
+const char kEnableMdStorageManager[] = "enable-md-storage-manager";

[michaelpg, 2016/10/01 01:41:05]

shouldn't we only have one of these flags?

[fukino, 2016/10/03 18:40:42]

I used ENABLE_DISABLE_VALUE_TYPE to have a default value so that we can easily
change the default setting of MD settings manager back and forth.

Is it better to use single value (e.g. enable-md-storage-manager), and when we
enable it by default we should delete the flag?

[michaelpg, 2016/10/03 23:44:44]

Generally yes, is it important that we be able to disable this after shipping
it?

[fukino, 2016/10/04 09:03:53]

Got it. I updated the CL to use a single value flag to enable md storage
manager.

+
 // Enables suggestions while typing on a physical keyboard.
 const char kEnablePhysicalKeyboardAutocorrect[] =
     "enable-physical-keyboard-autocorrect";
 
 // Enables request of tablet site (via user agent override).
 const char kEnableRequestTabletSite[] = "enable-request-tablet-site";
 
 // Enables using screenshots in tests and seets mode.
 const char kEnableScreenshotTestingWithMode[] =
     "enable-screenshot-testing-with-mode";
@@ skipping 207 matching lines @@
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   if (!command_line->HasSwitch(kTestCrosGaiaIdMigration))
     return false;
 
   return command_line->GetSwitchValueASCII(kTestCrosGaiaIdMigration) ==
          kTestCrosGaiaIdMigrationStarted;
 }
 
 }  // namespace switches
 }  // namespace chromeos