Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2348863002: Revert of Roll recipe dependencies (nontrivial). (Closed)

Created:
4 years, 3 months ago by tandrii(chromium)
Modified:
4 years, 3 months ago
Reviewers:
recipe-roller
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll recipe dependencies (nontrivial). (patchset #1 id:1 of https://codereview.chromium.org/2343013004/ ) Reason for revert: broke win_chromium_x64_rel_ng/builds/281022 because of apply_issue.bat calls local python. Original issue's description: > Roll recipe dependencies (nontrivial). > > This is an automated CL created by the recipe roller. This CL rolls recipe > changes from upstream projects (e.g. depot_tools) into downstream projects > (e.g. tools/build). > > Please review the expectation changes, and LGTM as normal. The recipe roller > will *NOT* CQ the change itself, so you must CQ the change manually. > > More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug > (or complain) > > build: > https://crrev.com/07a33586eff8451bbc84366055c3cfa36e7b6fea Roll recipe dependencies (nontrivial). (recipe-roller@chromium.org) > depot_tools: > https://crrev.com/972ac5040176acd90c8a1ce412f75d19f77cc4e8 bot_update: ensure correct depot_tools checkout is used. (tandrii@chromium.org) > > R=tandrii@chromium.org,recipe-roller@chromium.org > BUG=635641, 647446 > NOTRY=True > > Recipe-Tryjob-Bypass-Reason: Autoroller > Bugdroid-Send-Email: False > Committed: https://crrev.com/fd83e754f046fe29f120103423b19bd33717e36d > Cr-Commit-Position: refs/heads/master@{#419122} TBR=recipe-roller@chromium.org,recipe-roller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635641, 647446 Committed: https://crrev.com/6bb34d9b9ea1590a49b32a8a97fa223df282f66c Cr-Commit-Position: refs/heads/master@{#419126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -60 lines) Patch
M infra/config/recipes.cfg View 1 chunk +2 lines, -2 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/get_perf_test_list_old_data.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/host_info_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/missing_device.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/provision_devices.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/src_side_script_fails.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/android/perf.expected/test_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_fail.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_pass.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json View 2 chunks +2 lines, -2 lines 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json View 2 chunks +2 lines, -2 lines 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json View 2 chunks +2 lines, -2 lines 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json View 2 chunks +2 lines, -2 lines 0 comments Download
M infra/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/minimal_pass_continues.json View 2 chunks +2 lines, -2 lines 0 comments Download
M infra/recipes/blink_downstream.expected/too_many_failures_for_retcode.json View 2 chunks +2 lines, -2 lines 0 comments Download
M infra/recipes/blink_downstream.expected/webkit_tests_interrupted.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/blink_downstream.expected/webkit_tests_unexpected_error.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/canary.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/chromium.expected/builder.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/chromium.expected/tester.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/recipes/chromium_trybot.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
tandrii(chromium)
Created Revert of Roll recipe dependencies (nontrivial).
4 years, 3 months ago (2016-09-16 07:50:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348863002/1
4 years, 3 months ago (2016-09-16 07:50:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 07:52:14 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 07:54:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bb34d9b9ea1590a49b32a8a97fa223df282f66c
Cr-Commit-Position: refs/heads/master@{#419126}

Powered by Google App Engine
This is Rietveld 408576698