Prevent navigations within fullscreen webapps from being intercepted.

Prevent navigations within fullscreen webapps from being intercepted.

If a native app and a PWA are installed which handle the same URLs,
a navigation within the PWA may open the intent picker to ask the user
if they wish to browse in the native app.

This CL stops the picker from appearing if the user is browsing within
the fullscreen PWA. It does not do so if the user is browsing the PWA
outside of the fullscreen standalone (i.e. launched from homescreen)
mode.

BUG=647569
Committed: https://crrev.com/671b9d029e9ead87a24fb38e5268dee3f4de7a96
Cr-Commit-Position: refs/heads/master@{#419406}

[dominickn, 2016-09-16 07:00:13]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 07:00:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-09-16 07:00:41]

dominickn@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[dominickn, 2016-09-16 07:00:42]

Hi Maria, WDYT? Thanks!

[commit-bot: I haz the power, 2016-09-16 07:02:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 07:02:29]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dominickn, 2016-09-16 07:07:46]

On 2016/09/16 07:00:42, dominickn wrote:
> Hi Maria, WDYT? Thanks!

(Aside from the need to rebase, which I will get to next week)

[Maria, 2016-09-16 21:58:46]

lgtm after you address the comments

https://codereview.chromium.org/2348853002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
(right):

https://codereview.chromium.org/2348853002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:246:
WindowAndroid.activityFromContext(mTab.getWindowAndroid().getContext().get());
Use getAvailableContext() helper from above. It'll help you avoid NPEs in this
call.

https://codereview.chromium.org/2348853002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
(right):

https://codereview.chromium.org/2348853002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java:1009:

nit: extra newline

https://codereview.chromium.org/2348853002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java:1150:
public boolean mIsWithinCurrentWebappScope = false;
no need to initialize to false, that's the default value.

[dominickn, 2016-09-19 00:42:58]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 00:43:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-09-19 01:00:30]

Thanks!

https://codereview.chromium.org/2348853002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
(right):

https://codereview.chromium.org/2348853002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java:246:
WindowAndroid.activityFromContext(mTab.getWindowAndroid().getContext().get());
On 2016/09/16 21:58:46, Maria wrote:
> Use getAvailableContext() helper from above. It'll help you avoid NPEs in this
> call.

Done.

https://codereview.chromium.org/2348853002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
(right):

https://codereview.chromium.org/2348853002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java:1009:

On 2016/09/16 21:58:46, Maria wrote:
> nit: extra newline

Done.

https://codereview.chromium.org/2348853002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java:1150:
public boolean mIsWithinCurrentWebappScope = false;
On 2016/09/16 21:58:46, Maria wrote:
> no need to initialize to false, that's the default value.

Done.

[commit-bot: I haz the power, 2016-09-19 01:24:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 01:24:49]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-09-19 01:27:25]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2016-09-19 01:27:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/2348853002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-09-19 01:27:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 01:32:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-19 01:34:26]

Description was changed from

==========
Prevent navigations within fullscreen webapps from being intercepted.

If a native app and a PWA are installed which handle the same URLs,
a navigation within the PWA may open the intent picker to ask the user
if they wish to browse in the native app.

This CL stops the picker from appearing if the user is browsing within
the fullscreen PWA. It does not do so if the user is browsing the PWA
outside of the fullscreen standalone (i.e. launched from homescreen)
mode.

BUG=647569
==========

to

==========
Prevent navigations within fullscreen webapps from being intercepted.

If a native app and a PWA are installed which handle the same URLs,
a navigation within the PWA may open the intent picker to ask the user
if they wish to browse in the native app.

This CL stops the picker from appearing if the user is browsing within
the fullscreen PWA. It does not do so if the user is browsing the PWA
outside of the fullscreen standalone (i.e. launched from homescreen)
mode.

BUG=647569

Committed: https://crrev.com/671b9d029e9ead87a24fb38e5268dee3f4de7a96
Cr-Commit-Position: refs/heads/master@{#419406}
==========

[commit-bot: I haz the power, 2016-09-19 01:34:27]

Patchset 2 (id:??) landed as
https://crrev.com/671b9d029e9ead87a24fb38e5268dee3f4de7a96
Cr-Commit-Position: refs/heads/master@{#419406}