chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java - Issue 2348853002: Prevent navigations within fullscreen webapps from being intercepted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java

Issue 2348853002: Prevent navigations within fullscreen webapps from being intercepted. (Closed)

Patch Set: Address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java

index c7009f8ca27b2263c92c8936789cf0314542758a..ce40947e8c1bfd2447e7962b7b44c341ab6f47da 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java

@@ -35,6 +35,12 @@ interface ExternalNavigationDelegate {

boolean isSpecializedHandlerAvailable(List<ResolveInfo> infos);

/**

+ * Returns true if the current activity is a webapp and {@params url} lies within the scope of

+ * that webapp.

+ */

+ boolean isWithinCurrentWebappScope(String url);

+ /**

* Returns the number of specialized intent handlers in {@params infos}. Specialized intent

* handlers are intent handlers which handle only a few URLs (e.g. google maps or youtube).

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java » ('j') | no next file with comments »