Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2348693003: [HBD] Placeholder for Flash content without fallback. (Closed)

Created:
4 years, 3 months ago by tommycli
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[HBD] Placeholder for Flash content without fallback. BUG=641626 Committed: https://crrev.com/c0c4f94ef78d1b38ffd59ebaf03627a7b31b17b2 Cr-Commit-Position: refs/heads/master@{#419532}

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 2 chunks +7 lines, -1 line 0 comments Download
A chrome/renderer/resources/plugins/prefer_html_plugin.html View 1 1 chunk +44 lines, -0 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
tommycli
bauerb: PTAL, thanks!
4 years, 3 months ago (2016-09-15 23:37:49 UTC) #2
Bernhard Bauer
lgtm https://codereview.chromium.org/2348693003/diff/1/chrome/common/render_messages.h File chrome/common/render_messages.h (right): https://codereview.chromium.org/2348693003/diff/1/chrome/common/render_messages.h#newcode46 chrome/common/render_messages.h:46: kFlashHiddenPreferHtml, Can you sort these? https://codereview.chromium.org/2348693003/diff/1/chrome/renderer/resources/plugins/prefer_html_plugin.html File chrome/renderer/resources/plugins/prefer_html_plugin.html ...
4 years, 3 months ago (2016-09-16 10:21:04 UTC) #3
tommycli
bauerb: Thank you sir! https://codereview.chromium.org/2348693003/diff/1/chrome/common/render_messages.h File chrome/common/render_messages.h (right): https://codereview.chromium.org/2348693003/diff/1/chrome/common/render_messages.h#newcode46 chrome/common/render_messages.h:46: kFlashHiddenPreferHtml, On 2016/09/16 10:21:03, Bernhard ...
4 years, 3 months ago (2016-09-16 15:43:19 UTC) #5
tommycli
tsepez: PTAL render_messages.h thakis: PTAL chrome/renderer/chrome_content_renderer_client.cc Thanks all!
4 years, 3 months ago (2016-09-16 15:44:58 UTC) #7
Tom Sepez
Messages LGTM
4 years, 3 months ago (2016-09-16 15:53:11 UTC) #8
tommycli
Nico: PTAL, Thanks!
4 years, 3 months ago (2016-09-19 17:51:01 UTC) #9
Nico
chrome_content_renderer_client lgtm
4 years, 3 months ago (2016-09-19 17:58:07 UTC) #10
tommycli
thank you all!
4 years, 3 months ago (2016-09-19 18:25:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348693003/20001
4 years, 3 months ago (2016-09-19 18:26:31 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 19:35:23 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:03:09 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c0c4f94ef78d1b38ffd59ebaf03627a7b31b17b2
Cr-Commit-Position: refs/heads/master@{#419532}

Powered by Google App Engine
This is Rietveld 408576698