Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5637)

Unified Diff: chrome/renderer/plugins/chrome_plugin_placeholder.cc

Issue 2348693003: [HBD] Placeholder for Flash content without fallback. (Closed)
Patch Set: address comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/plugins/chrome_plugin_placeholder.cc
diff --git a/chrome/renderer/plugins/chrome_plugin_placeholder.cc b/chrome/renderer/plugins/chrome_plugin_placeholder.cc
index 67f82bf8d0e7fe3f2180a6f32cf59210feb1fad5..2995e7837fcd723dcc7421917cd9421723eaa013 100644
--- a/chrome/renderer/plugins/chrome_plugin_placeholder.cc
+++ b/chrome/renderer/plugins/chrome_plugin_placeholder.cc
@@ -224,6 +224,10 @@ void ChromePluginPlaceholder::OpenAboutPluginsCallback() {
new ChromeViewHostMsg_OpenAboutPlugins(routing_id()));
}
+void ChromePluginPlaceholder::ShowPermissionBubbleCallback() {
+ // TODO(tommycli): Show a permission bubble in the browser process.
+}
+
#if defined(ENABLE_PLUGIN_INSTALLATION)
void ChromePluginPlaceholder::OnDidNotFindMissingPlugin() {
SetMessage(l10n_util::GetStringUTF16(IDS_PLUGIN_NOT_FOUND));
@@ -417,7 +421,9 @@ gin::ObjectTemplateBuilder ChromePluginPlaceholder::GetObjectTemplateBuilder(
"didFinishLoading",
&ChromePluginPlaceholder::DidFinishLoadingCallback)
.SetMethod("openAboutPlugins",
- &ChromePluginPlaceholder::OpenAboutPluginsCallback);
+ &ChromePluginPlaceholder::OpenAboutPluginsCallback)
+ .SetMethod("showPermissionBubble",
+ &ChromePluginPlaceholder::ShowPermissionBubbleCallback);
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnablePluginPlaceholderTesting)) {
« no previous file with comments | « chrome/renderer/plugins/chrome_plugin_placeholder.h ('k') | chrome/renderer/resources/plugins/prefer_html_plugin.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698