Issue 234853002: Fix KURL::copy such that it also copies m_innerURL when available

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 234853002: Fix KURL::copy such that it also copies m_innerURL when available (Closed)

Created:
6 years, 8 months ago by robwu

Modified:
6 years, 8 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix KURL::copy such that it also copies m_innerURL when available BUG=362061 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171365

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	Source/platform/weborigin/KURL.cpp	View		1 chunk	+1 line, -1 line	2 comments	Download
	M	Source/platform/weborigin/KURLTest.cpp	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

LGTM https://codereview.chromium.org/234853002/diff/1/Source/platform/weborigin/KURL.cpp File Source/platform/weborigin/KURL.cpp (left): https://codereview.chromium.org/234853002/diff/1/Source/platform/weborigin/KURL.cpp#oldcode262 Source/platform/weborigin/KURL.cpp:262: if (result.m_innerURL) O_o

6 years, 8 months ago (2014-04-11 18:40:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob@robwu.nl/234853002/1

6 years, 8 months ago (2014-04-11 19:13:36 UTC) #4

ericu

6 years, 8 months ago (2014-04-14 17:31:54 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/234853002/diff/1/Source/platform/weborigin/KU...
File Source/platform/weborigin/KURL.cpp (left):

https://codereview.chromium.org/234853002/diff/1/Source/platform/weborigin/KU...
Source/platform/weborigin/KURL.cpp:262: if (result.m_innerURL)
On 2014/04/11 18:40:02, abarth wrote:
> O_o

Ouch.  Thanks for the fix.

Expand Messages | Collapse Messages