Source/platform/weborigin/KURL.cpp - Issue 234853002: Fix KURL::copy such that it also copies m_innerURL when available

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/weborigin/KURL.cpp

Issue 234853002: Fix KURL::copy such that it also copies m_innerURL when available (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/weborigin/KURL.cpp

diff --git a/Source/platform/weborigin/KURL.cpp b/Source/platform/weborigin/KURL.cpp

index e821cbd42c686a0f7c517b015381f9f76a5ddfbd..f9fec104c97b6ff66cd8b92c0551acc6b50f2f60 100644

--- a/Source/platform/weborigin/KURL.cpp

+++ b/Source/platform/weborigin/KURL.cpp

@@ -259,7 +259,7 @@ KURL KURL::copy() const

result.m_protocolIsInHTTPFamily = m_protocolIsInHTTPFamily;

result.m_parsed = m_parsed;

result.m_string = m_string.isolatedCopy();

- if (result.m_innerURL)

abarth-chromium 2014/04/11 18:40:02 O_o

ericu 2014/04/14 17:31:55 Ouch. Thanks for the fix.

+ if (m_innerURL)

result.m_innerURL = adoptPtr(new KURL(m_innerURL->copy()));

return result;

}

« no previous file with comments | « no previous file | Source/platform/weborigin/KURLTest.cpp » ('j') | no next file with comments »