Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/builtins/builtins.h

Issue 2348493003: [builtins] move String.prototype[@@iterator] to C++ builtin (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/bootstrapper.cc ('K') | « src/bootstrapper.cc ('k') | src/builtins/builtins-string.cc » ('j') | src/factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins.h
diff --git a/src/builtins/builtins.h b/src/builtins/builtins.h
index 1a963165967e3c45777b75249cc4824b16787171..f779d719c823665346693cb77bea47d699fc3ac9 100644
--- a/src/builtins/builtins.h
+++ b/src/builtins/builtins.h
@@ -546,6 +546,11 @@ namespace internal {
CPP(StringPrototypeTrimRight) \
/* ES6 section 21.1.3.28 String.prototype.valueOf () */ \
TFJ(StringPrototypeValueOf, 1) \
+ /* ES6 #sec-string.prototype-@@iterator */ \
+ CPP(StringCreateIterator) \
Benedikt Meurer 2016/09/15 17:34:33 For consistency, please rename this to StringProto
+ \
+ /* StringIterator */ \
+ CPP(StringIteratorNext) \
Benedikt Meurer 2016/09/15 17:34:33 And this to StringIteratorPrototypeNext
\
/* Symbol */ \
CPP(SymbolConstructor) \
« src/bootstrapper.cc ('K') | « src/bootstrapper.cc ('k') | src/builtins/builtins-string.cc » ('j') | src/factory.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698