Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/builtins/builtins.h

Issue 2348493003: [builtins] move String.prototype[@@iterator] to C++ builtin (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_BUILTINS_BUILTINS_H_ 5 #ifndef V8_BUILTINS_BUILTINS_H_
6 #define V8_BUILTINS_BUILTINS_H_ 6 #define V8_BUILTINS_BUILTINS_H_
7 7
8 #include "src/base/flags.h" 8 #include "src/base/flags.h"
9 #include "src/handles.h" 9 #include "src/handles.h"
10 10
(...skipping 528 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 CPP(StringPrototypeLocaleCompare) \ 539 CPP(StringPrototypeLocaleCompare) \
540 /* ES6 section 21.1.3.12 String.prototype.normalize ( [form] ) */ \ 540 /* ES6 section 21.1.3.12 String.prototype.normalize ( [form] ) */ \
541 CPP(StringPrototypeNormalize) \ 541 CPP(StringPrototypeNormalize) \
542 /* ES6 section 21.1.3.25 String.prototype.toString () */ \ 542 /* ES6 section 21.1.3.25 String.prototype.toString () */ \
543 TFJ(StringPrototypeToString, 1) \ 543 TFJ(StringPrototypeToString, 1) \
544 CPP(StringPrototypeTrim) \ 544 CPP(StringPrototypeTrim) \
545 CPP(StringPrototypeTrimLeft) \ 545 CPP(StringPrototypeTrimLeft) \
546 CPP(StringPrototypeTrimRight) \ 546 CPP(StringPrototypeTrimRight) \
547 /* ES6 section 21.1.3.28 String.prototype.valueOf () */ \ 547 /* ES6 section 21.1.3.28 String.prototype.valueOf () */ \
548 TFJ(StringPrototypeValueOf, 1) \ 548 TFJ(StringPrototypeValueOf, 1) \
549 /* ES6 #sec-string.prototype-@@iterator */ \
550 CPP(StringCreateIterator) \
Benedikt Meurer 2016/09/15 17:34:33 For consistency, please rename this to StringProto
551 \
552 /* StringIterator */ \
553 CPP(StringIteratorNext) \
Benedikt Meurer 2016/09/15 17:34:33 And this to StringIteratorPrototypeNext
549 \ 554 \
550 /* Symbol */ \ 555 /* Symbol */ \
551 CPP(SymbolConstructor) \ 556 CPP(SymbolConstructor) \
552 CPP(SymbolConstructor_ConstructStub) \ 557 CPP(SymbolConstructor_ConstructStub) \
553 /* ES6 section 19.4.3.4 Symbol.prototype [ @@toPrimitive ] ( hint ) */ \ 558 /* ES6 section 19.4.3.4 Symbol.prototype [ @@toPrimitive ] ( hint ) */ \
554 TFJ(SymbolPrototypeToPrimitive, 2) \ 559 TFJ(SymbolPrototypeToPrimitive, 2) \
555 /* ES6 section 19.4.3.2 Symbol.prototype.toString ( ) */ \ 560 /* ES6 section 19.4.3.2 Symbol.prototype.toString ( ) */ \
556 TFJ(SymbolPrototypeToString, 1) \ 561 TFJ(SymbolPrototypeToString, 1) \
557 /* ES6 section 19.4.3.3 Symbol.prototype.valueOf ( ) */ \ 562 /* ES6 section 19.4.3.3 Symbol.prototype.valueOf ( ) */ \
558 TFJ(SymbolPrototypeValueOf, 1) \ 563 TFJ(SymbolPrototypeValueOf, 1) \
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
707 712
708 friend class Isolate; 713 friend class Isolate;
709 714
710 DISALLOW_COPY_AND_ASSIGN(Builtins); 715 DISALLOW_COPY_AND_ASSIGN(Builtins);
711 }; 716 };
712 717
713 } // namespace internal 718 } // namespace internal
714 } // namespace v8 719 } // namespace v8
715 720
716 #endif // V8_BUILTINS_BUILTINS_H_ 721 #endif // V8_BUILTINS_BUILTINS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698