Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 234843004: Roll DEPS for breakpad 1295:1313 (Closed)

Created:
6 years, 8 months ago by rmcilroy
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Mark Mentovai, Anton
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Roll DEPS for breakpad 1295:1313 Add Arm64 and x64 support to BreakPad for Linux/Android clients r1298: Update GYP dependency to r1886. r1299: fix races in CrashGenerator::CreateChildCrash r1300: Remove some unecessary Android system header definitions. r1301: First cut at adding arm64 Linux / Android support to Breakpad. r1302: Add Arm64 version of breakpad_getcontext for Android. r1303: Fix ElfCoreDumpTest.ValidCoreFile unit test. r1304: Move build configuration to root of repository. r1305: Add Arm64 support to breakpad unittests. r1306: Fix aarch64 ucontext layout on Android. r1307: Increase Breakpad's signal handler stack size. r1308: Moving directory 'build' one level up as it collides. r1309: Adding support for 64-bit Windows modules to ms_symbol_server_converter. r1310: Fill in CPU info in mini-dump for Arm64. r1311: Add x64 version of getcontext. r1312: Update offset of fpregs_mem on x64. r1313: [Android]: Fix hang in CreateChildCrash() on Android. BUG=354405, 335641, 346626 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263886

Patch Set 1 #

Patch Set 2 : Update to 1313 to pull in Android hang fix and x64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
rmcilroy
Primiano - could you PTAL, thanks.
6 years, 8 months ago (2014-04-11 15:00:28 UTC) #1
Primiano Tucci (use gerrit)
LGTM modulo commit message. I am not sure if there is an official rule for ...
6 years, 8 months ago (2014-04-11 15:59:10 UTC) #2
rmcilroy
On 2014/04/11 15:59:10, Primiano Tucci wrote: > LGTM modulo commit message. > I am not ...
6 years, 8 months ago (2014-04-11 16:03:01 UTC) #3
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 8 months ago (2014-04-11 16:03:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/234843004/1
6 years, 8 months ago (2014-04-11 16:04:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 23:20:17 UTC) #6
Primiano Tucci (use gerrit)
The CQ bit was checked by primiano@chromium.org
6 years, 8 months ago (2014-04-13 19:19:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/234843004/1
6 years, 8 months ago (2014-04-13 19:19:34 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 02:30:08 UTC) #10
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 8 months ago (2014-04-15 10:12:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/234843004/20001
6 years, 8 months ago (2014-04-15 10:13:42 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 13:07:47 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-15 13:07:47 UTC) #15
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 8 months ago (2014-04-15 13:18:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/234843004/20001
6 years, 8 months ago (2014-04-15 13:18:56 UTC) #17
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 16:56:53 UTC) #18
Message was sent while issue was closed.
Change committed as 263886

Powered by Google App Engine
This is Rietveld 408576698