[Signin Error Dialog] (3/3) Added the triggering code

chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

Index: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
diff --git a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
index d85e39091424b0a2fbec5c6b34b98025da167fce..8d3c25a74ba0538213a6d06dd209c514a4b57595 100644
--- a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
+++ b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
@@ -25,6 +25,7 @@ const int kPasswordCombinedFixedGaiaViewWidth = 360;
 const int kFixedGaiaViewHeight = 612;
 const int kModalDialogWidth = 448;
 const int kSyncConfirmationDialogHeight = 487;
+const int kSigninErrorDialogHeight = 164;
 
 SigninViewControllerDelegateViews::SigninViewControllerDelegateViews(
     SigninViewController* signin_view_controller,
@@ -153,6 +154,21 @@ SigninViewControllerDelegateViews::CreateSyncConfirmationWebView(
   return web_view;
 }
 
+views::WebView* SigninViewControllerDelegateViews::CreateSigninErrorWebView(

[sky, 2016/09/21 16:14:39]

It's hard to reason about lifetime with raw pointers. Please return a unique_ptr
here and why supplying the WebView to SigninViewControllerDelegateViews.

[anthonyvd, 2016/09/22 16:52:01]

Agreed, done. Could you clarify something about views ownership? I'm under the
impression that a view owns its subviews (and thus deletes them when it's
deleted itself). Is that correct? 

For example, in this case SigninViewControllerDelegate is a WidgetDelegate
subclass that doesn't own the WebView that it returns through GetContentsView. I
based this ownership model on the way WidgetDelegate handles its
default_content_view_ member (it instantiates it with new but doesn't delete
it).

Thanks in advance, I just want to make sure I'm not leaking anything!

[sky, 2016/09/22 20:29:35]

You are correct for the common case. The exception to that is if someone calls
set_owned_by_client() on a view. When a view is destroyed it iterates over the
children deleting those marked as not owned-by-client and removing those marked
as owned-by-client.
Widget adds the view returned from GetContentsView as a child of the RootView.
So, as long as you haven't called set_owned_by_client() on the WebView it'll be
deleted by virtual of the RootView being deleted.

+    Browser* browser) {
+  views::WebView* web_view = new views::WebView(browser->profile());
+  web_view->LoadInitialURL(GURL(chrome::kChromeUISigninErrorURL));
+
+  int max_height = browser->window()
+                       ->GetWebContentsModalDialogHost()
+                       ->GetMaximumDialogSize()
+                       .height();
+  web_view->SetPreferredSize(gfx::Size(
+      kModalDialogWidth, std::min(kSigninErrorDialogHeight, max_height)));
+
+  return web_view;
+}
+
 SigninViewControllerDelegate*
 SigninViewControllerDelegate::CreateModalSigninDelegate(
     SigninViewController* signin_view_controller,
@@ -175,3 +191,13 @@ SigninViewControllerDelegate::CreateSyncConfirmationDelegate(
       SigninViewControllerDelegateViews::CreateSyncConfirmationWebView(browser),
       browser, true);
 }
+
+SigninViewControllerDelegate*
+SigninViewControllerDelegate::CreateSigninErrorDelegate(
+    SigninViewController* signin_view_controller,
+    Browser* browser) {
+  return new SigninViewControllerDelegateViews(
+      signin_view_controller,
+      SigninViewControllerDelegateViews::CreateSigninErrorWebView(browser),
+      browser, true);
+}