[Signin Error Dialog] (3/3) Added the triggering code

chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h"
 
 #include "base/macros.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_avatar_icon_util.h"
 #include "chrome/browser/signin/signin_promo.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/common/url_constants.h"
 #include "components/constrained_window/constrained_window_views.h"
 #include "components/signin/core/common/profile_management_switches.h"
 #include "components/web_modal/web_contents_modal_dialog_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/views/controls/webview/webview.h"
 #include "ui/views/widget/widget.h"
 
 const int kPasswordCombinedFixedGaiaViewHeight = 440;
 const int kPasswordCombinedFixedGaiaViewWidth = 360;
 const int kFixedGaiaViewHeight = 612;
 const int kModalDialogWidth = 448;
 const int kSyncConfirmationDialogHeight = 487;
+const int kSigninErrorDialogHeight = 164;
 
 SigninViewControllerDelegateViews::SigninViewControllerDelegateViews(
     SigninViewController* signin_view_controller,
     views::WebView* content_view,
     Browser* browser,
     bool wait_for_size)
     : SigninViewControllerDelegate(signin_view_controller,
                                    content_view->GetWebContents()),
       content_view_(content_view),
       modal_signin_widget_(nullptr),
@@ skipping 108 matching lines @@
       ->window()
       ->GetWebContentsModalDialogHost()
       ->GetMaximumDialogSize().height();
   web_view->SetPreferredSize(
       gfx::Size(kModalDialogWidth,
                 std::min(kSyncConfirmationDialogHeight, max_height)));
 
   return web_view;
 }
 
+views::WebView* SigninViewControllerDelegateViews::CreateSigninErrorWebView(

[sky, 2016/09/21 16:14:39]

It's hard to reason about lifetime with raw pointers. Please return a unique_ptr
here and why supplying the WebView to SigninViewControllerDelegateViews.

[anthonyvd, 2016/09/22 16:52:01]

Agreed, done. Could you clarify something about views ownership? I'm under the
impression that a view owns its subviews (and thus deletes them when it's
deleted itself). Is that correct? 

For example, in this case SigninViewControllerDelegate is a WidgetDelegate
subclass that doesn't own the WebView that it returns through GetContentsView. I
based this ownership model on the way WidgetDelegate handles its
default_content_view_ member (it instantiates it with new but doesn't delete
it).

Thanks in advance, I just want to make sure I'm not leaking anything!

[sky, 2016/09/22 20:29:35]

You are correct for the common case. The exception to that is if someone calls
set_owned_by_client() on a view. When a view is destroyed it iterates over the
children deleting those marked as not owned-by-client and removing those marked
as owned-by-client.
Widget adds the view returned from GetContentsView as a child of the RootView.
So, as long as you haven't called set_owned_by_client() on the WebView it'll be
deleted by virtual of the RootView being deleted.

+    Browser* browser) {
+  views::WebView* web_view = new views::WebView(browser->profile());
+  web_view->LoadInitialURL(GURL(chrome::kChromeUISigninErrorURL));
+
+  int max_height = browser->window()
+                       ->GetWebContentsModalDialogHost()
+                       ->GetMaximumDialogSize()
+                       .height();
+  web_view->SetPreferredSize(gfx::Size(
+      kModalDialogWidth, std::min(kSigninErrorDialogHeight, max_height)));
+
+  return web_view;
+}
+
 SigninViewControllerDelegate*
 SigninViewControllerDelegate::CreateModalSigninDelegate(
     SigninViewController* signin_view_controller,
     profiles::BubbleViewMode mode,
     Browser* browser,
     signin_metrics::AccessPoint access_point) {
   return new SigninViewControllerDelegateViews(
       signin_view_controller,
       SigninViewControllerDelegateViews::CreateGaiaWebView(
           nullptr, mode, browser, access_point),
       browser, false);
 }
 
 SigninViewControllerDelegate*
 SigninViewControllerDelegate::CreateSyncConfirmationDelegate(
     SigninViewController* signin_view_controller,
     Browser* browser) {
   return new SigninViewControllerDelegateViews(
       signin_view_controller,
       SigninViewControllerDelegateViews::CreateSyncConfirmationWebView(browser),
       browser, true);
 }
+
+SigninViewControllerDelegate*
+SigninViewControllerDelegate::CreateSigninErrorDelegate(
+    SigninViewController* signin_view_controller,
+    Browser* browser) {
+  return new SigninViewControllerDelegateViews(
+      signin_view_controller,
+      SigninViewControllerDelegateViews::CreateSigninErrorWebView(browser),
+      browser, true);
+}