Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2348383006: Fix mustCallSuper to ignore methods from interfaces (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +11 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 3 months ago (2016-09-20 22:07:58 UTC) #2
scheglov
LGTM
4 years, 3 months ago (2016-09-20 23:17:37 UTC) #3
Brian Wilkerson
4 years, 2 months ago (2016-09-21 15:03:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6062d5d6bdc7d3c0fb634c5e74c03a578ce57dd7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698