Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: pkg/analyzer/test/generated/hint_code_test.dart

Issue 2348383006: Fix mustCallSuper to ignore methods from interfaces (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/error_verifier.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/hint_code_test.dart
diff --git a/pkg/analyzer/test/generated/hint_code_test.dart b/pkg/analyzer/test/generated/hint_code_test.dart
index 750ef781a9e8e51d160cf6b77e014eb88ff130f3..0b37222a7e4c7595e07925c623187934496b6aeb 100644
--- a/pkg/analyzer/test/generated/hint_code_test.dart
+++ b/pkg/analyzer/test/generated/hint_code_test.dart
@@ -1859,6 +1859,23 @@ class B extends A {
verify([source]);
}
+ void test_mustCallSuper_fromInterface() {
+ Source source = addSource(r'''
+import 'package:meta/meta.dart';
+class A {
+ @mustCallSuper
+ void a() {}
+}
+class C implements A {
+ @override
+ void a() {}
+}
+''');
+ computeLibrarySourceErrors(source);
+ assertErrors(source, []);
+ verify([source]);
+ }
+
void test_mustCallSuper_indirect() {
Source source = addSource(r'''
import 'package:meta/meta.dart';
@@ -1882,7 +1899,7 @@ class D extends C {
verify([source]);
}
- void test_mustCallSuper_OK() {
+ void test_mustCallSuper_overridden() {
Source source = addSource(r'''
import 'package:meta/meta.dart';
class A {
« no previous file with comments | « pkg/analyzer/lib/src/generated/error_verifier.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698