[MD-Settings A11y] Set alt text for expandable buttons.

[MD-Settings A11y] Set alt text for expandable buttons.

No UI change, this only affects the alt-label for the buttons.

BUG=626875
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e
Cr-Commit-Position: refs/heads/master@{#420364}

[hcarmona, 2016-09-19 16:52:34]

Description was changed from

==========
[MD-Settings A11y] Set alt text for expandable buttons.

No UI change, this only affects the alt-label for the buttons.

BUG=626875
==========

to

==========
[MD-Settings A11y] Set alt text for expandable buttons.

No UI change, this only affects the alt-label for the buttons.

BUG=626875
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-09-19 16:52:36]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 16:52:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 16:55:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 16:55:25]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hcarmona, 2016-09-19 17:04:02]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 17:04:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:06:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:07:00]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2016-09-19 19:15:12]

Description was changed from

==========
[MD-Settings A11y] Set alt text for expandable buttons.

No UI change, this only affects the alt-label for the buttons.

BUG=626875
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD-Settings A11y] Set alt text for expandable buttons.

No UI change, this only affects the alt-label for the buttons.

BUG=626875
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-09-19 19:15:12]

hcarmona@chromium.org changed reviewers:
+ stevenjb@chromium.org

[hcarmona, 2016-09-19 19:15:57]

Patchset #1 (id:1) has been deleted

[hcarmona, 2016-09-19 19:22:10]

PTAL, Thanks :-)

[stevenjb, 2016-09-20 16:25:33]

https://codereview.chromium.org/2348363002/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/network/cr_network_select.html (right):

https://codereview.chromium.org/2348363002/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/network/cr_network_select.html:22: alt="Show
available network connections"
We do have translations in this directory, see cr_network_list_item.js for an
example. There is a helper function in md_settings_localized_strings_provider.cc
(for now),  AddCrNetworkStrings(), that gets called by any WebUi using these
elements.

[hcarmona, 2016-09-21 21:01:46]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 21:02:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 22:57:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 22:57:19]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2016-09-22 14:57:12]

https://codereview.chromium.org/2348363002/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/network/cr_network_select.html (right):

https://codereview.chromium.org/2348363002/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/network/cr_network_select.html:22: alt="Show
available network connections"
On 2016/09/20 16:25:33, stevenjb wrote:
> We do have translations in this directory, see cr_network_list_item.js for an
> example. There is a helper function in
md_settings_localized_strings_provider.cc
> (for now),  AddCrNetworkStrings(), that gets called by any WebUi using these
> elements.
> 

Fixed. I missed this label. I've looked through to make sure I didn't
miss i18n for any others.

[stevenjb, 2016-09-22 15:52:15]

lgtm

[hcarmona, 2016-09-22 16:07:37]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2016-09-22 16:07:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 16:14:47]

Description was changed from

==========
[MD-Settings A11y] Set alt text for expandable buttons.

No UI change, this only affects the alt-label for the buttons.

BUG=626875
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD-Settings A11y] Set alt text for expandable buttons.

No UI change, this only affects the alt-label for the buttons.

BUG=626875
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-22 16:14:48]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-22 16:16:52]

Description was changed from

==========
[MD-Settings A11y] Set alt text for expandable buttons.

No UI change, this only affects the alt-label for the buttons.

BUG=626875
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD-Settings A11y] Set alt text for expandable buttons.

No UI change, this only affects the alt-label for the buttons.

BUG=626875
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e
Cr-Commit-Position: refs/heads/master@{#420364}
==========

[commit-bot: I haz the power, 2016-09-22 16:16:53]

Patchset 2 (id:??) landed as
https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e
Cr-Commit-Position: refs/heads/master@{#420364}