chrome/browser/resources/settings/internet_page/internet_detail_page.html - Issue 2348363002: [MD-Settings A11y] Set alt text for expandable buttons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.html

Issue 2348363002: [MD-Settings A11y] Set alt text for expandable buttons. (Closed)

Patch Set: feedback Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html ('k') | chrome/browser/resources/settings/internet_page/internet_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/internet_detail_page.html

diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.html b/chrome/browser/resources/settings/internet_page/internet_detail_page.html

index 032cd58d1c1c83bb2b611d0691625615e7e1e346..d98144179e5545bded14a012bb5e70ceeaf43e56 100644

--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.html

+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.html

@@ -184,7 +184,8 @@

<div class="settings-box" actionable on-tap="toggleAdvancedExpanded_"

hidden$="[[!showAdvanced_(networkProperties)]]">

<div class="advanced flex">$i18n{networkSectionAdvanced}</div>

- <cr-expand-button id="expandButton" expanded="{{advancedExpanded_}}">

+ <cr-expand-button id="expandButton" expanded="{{advancedExpanded_}}"

+ alt="$i18n{networkSectionAdvancedExpandA11yLabel}">

</cr-expand-button>

</div>