Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 23483024: Assume FrameView::m_frame is never NULL (Closed)

Created:
7 years, 3 months ago by caseq
Modified:
7 years, 3 months ago
CC:
blink-reviews, kenneth.christiansen, aboxhall, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, dglazkov+blink, dmazzoni, jchaffraix+rendering
Visibility:
Public.

Description

Assume FrameView::m_frame is never NULL FrameView::clearFrame() is unused and we never pass a null frame pointer to FrameView::create(), so FrameView::m_frame should never be NULL. This removes FrameView::clearFrame() and removes m_frame check from conditional expressions. BUG= R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -39 lines) Patch
M Source/core/accessibility/AccessibilityRenderObject.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/FrameView.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/page/FrameView.cpp View 10 chunks +6 lines, -23 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/plugins/IFrameShimSupport.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
caseq
7 years, 3 months ago (2013-08-30 15:59:34 UTC) #1
eseidel
7 years, 3 months ago (2013-08-31 04:11:38 UTC) #2
abarth-chromium
LGTM Please consider making FrameView::frame return a reference rather than a pointer. :)
7 years, 3 months ago (2013-08-31 05:58:30 UTC) #3
caseq
Committed patchset #1 manually as r157068 (presubmit successful).
7 years, 3 months ago (2013-09-02 08:08:43 UTC) #4
caseq
7 years, 3 months ago (2013-09-02 08:38:13 UTC) #5
Message was sent while issue was closed.
On 2013/08/31 05:58:30, abarth wrote:
> LGTM
> 
> Please consider making FrameView::frame return a reference rather than a
> pointer.  :)

Sure! It's somewhat bigger, though, so extracting it to a separate CL:
https://codereview.chromium.org/23728003

Powered by Google App Engine
This is Rietveld 408576698