[crankshaft] Protect against deopt loops from string length overflows.

[crankshaft] Protect against deopt loops from string length overflows.

Crankshaft just unconditionally deoptimizes the code when the length of
a string addition result would overflow. In order to protect against
deopt loops we insert a global protector cell.

We will use the same mechanism for inlining certain string additions
into TurboFan as well, and protecting against overflow (we will also
extend this to deal with String.prototype.concat and friends once we
get there).

BUG=v8:5404
R=jarin@chromium.org,hpayer@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux64_msan_rel

Committed: https://crrev.com/cb19257a926a55209a6d6858ce26d51a0447ba71
Committed: https://crrev.com/d86038db25064fb40fbce6fc3b2fb67831f9e7b1
Cr-Original-Commit-Position: refs/heads/master@{#39511}
Cr-Commit-Position: refs/heads/master@{#39525}

[Benedikt Meurer, 2016-09-19 13:42:52]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 13:42:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2016-09-19 14:07:35]

lgtm

[commit-bot: I haz the power, 2016-09-19 14:10:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 14:10:30]

Dry run: This issue passed the CQ dry run.

[Jarin, 2016-09-19 15:01:15]

lgtm

[Benedikt Meurer, 2016-09-19 18:48:26]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-09-19 18:48:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 18:53:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-19 21:01:39]

Description was changed from

==========
[crankshaft] Protect against deopt loops from string length overflows.

Crankshaft just unconditionally deoptimizes the code when the length of
a string addition result would overflow. In order to protect against
deopt loops we insert a global protector cell.

We will use the same mechanism for inlining certain string additions
into TurboFan as well, and protecting against overflow (we will also
extend this to deal with String.prototype.concat and friends once we
get there).

BUG=v8:5404
R=jarin@chromium.org,hpayer@chromium.org
==========

to

==========
[crankshaft] Protect against deopt loops from string length overflows.

Crankshaft just unconditionally deoptimizes the code when the length of
a string addition result would overflow. In order to protect against
deopt loops we insert a global protector cell.

We will use the same mechanism for inlining certain string additions
into TurboFan as well, and protecting against overflow (we will also
extend this to deal with String.prototype.concat and friends once we
get there).

BUG=v8:5404
R=jarin@chromium.org,hpayer@chromium.org

Committed: https://crrev.com/cb19257a926a55209a6d6858ce26d51a0447ba71
Cr-Commit-Position: refs/heads/master@{#39511}
==========

[commit-bot: I haz the power, 2016-09-19 21:01:40]

Patchset 1 (id:??) landed as
https://crrev.com/cb19257a926a55209a6d6858ce26d51a0447ba71
Cr-Commit-Position: refs/heads/master@{#39511}

[Michael Achenbach, 2016-09-19 21:49:29]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2357433002/ by machenbach@chromium.org.

The reason for reverting is: Mean
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20....

[Benedikt Meurer, 2016-09-20 05:11:41]

Description was changed from

==========
[crankshaft] Protect against deopt loops from string length overflows.

Crankshaft just unconditionally deoptimizes the code when the length of
a string addition result would overflow. In order to protect against
deopt loops we insert a global protector cell.

We will use the same mechanism for inlining certain string additions
into TurboFan as well, and protecting against overflow (we will also
extend this to deal with String.prototype.concat and friends once we
get there).

BUG=v8:5404
R=jarin@chromium.org,hpayer@chromium.org

Committed: https://crrev.com/cb19257a926a55209a6d6858ce26d51a0447ba71
Cr-Commit-Position: refs/heads/master@{#39511}
==========

to

==========
[crankshaft] Protect against deopt loops from string length overflows.

Crankshaft just unconditionally deoptimizes the code when the length of
a string addition result would overflow. In order to protect against
deopt loops we insert a global protector cell.

We will use the same mechanism for inlining certain string additions
into TurboFan as well, and protecting against overflow (we will also
extend this to deal with String.prototype.concat and friends once we
get there).

BUG=v8:5404
R=jarin@chromium.org,hpayer@chromium.org

Committed: https://crrev.com/cb19257a926a55209a6d6858ce26d51a0447ba71
Cr-Commit-Position: refs/heads/master@{#39511}
==========

[Benedikt Meurer, 2016-09-20 05:12:29]

Description was changed from

==========
[crankshaft] Protect against deopt loops from string length overflows.

Crankshaft just unconditionally deoptimizes the code when the length of
a string addition result would overflow. In order to protect against
deopt loops we insert a global protector cell.

We will use the same mechanism for inlining certain string additions
into TurboFan as well, and protecting against overflow (we will also
extend this to deal with String.prototype.concat and friends once we
get there).

BUG=v8:5404
R=jarin@chromium.org,hpayer@chromium.org

Committed: https://crrev.com/cb19257a926a55209a6d6858ce26d51a0447ba71
Cr-Commit-Position: refs/heads/master@{#39511}
==========

to

==========
[crankshaft] Protect against deopt loops from string length overflows.

Crankshaft just unconditionally deoptimizes the code when the length of
a string addition result would overflow. In order to protect against
deopt loops we insert a global protector cell.

We will use the same mechanism for inlining certain string additions
into TurboFan as well, and protecting against overflow (we will also
extend this to deal with String.prototype.concat and friends once we
get there).

BUG=v8:5404
R=jarin@chromium.org,hpayer@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux64_msan_rel

Committed: https://crrev.com/cb19257a926a55209a6d6858ce26d51a0447ba71
Cr-Commit-Position: refs/heads/master@{#39511}
==========

[Benedikt Meurer, 2016-09-20 05:13:07]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-09-20 05:13:07]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org,
jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2348293002/#ps20001
(title: "Fix MSAN")

[commit-bot: I haz the power, 2016-09-20 05:13:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 05:58:45]

Description was changed from

==========
[crankshaft] Protect against deopt loops from string length overflows.

Crankshaft just unconditionally deoptimizes the code when the length of
a string addition result would overflow. In order to protect against
deopt loops we insert a global protector cell.

We will use the same mechanism for inlining certain string additions
into TurboFan as well, and protecting against overflow (we will also
extend this to deal with String.prototype.concat and friends once we
get there).

BUG=v8:5404
R=jarin@chromium.org,hpayer@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux64_msan_rel

Committed: https://crrev.com/cb19257a926a55209a6d6858ce26d51a0447ba71
Cr-Commit-Position: refs/heads/master@{#39511}
==========

to

==========
[crankshaft] Protect against deopt loops from string length overflows.

Crankshaft just unconditionally deoptimizes the code when the length of
a string addition result would overflow. In order to protect against
deopt loops we insert a global protector cell.

We will use the same mechanism for inlining certain string additions
into TurboFan as well, and protecting against overflow (we will also
extend this to deal with String.prototype.concat and friends once we
get there).

BUG=v8:5404
R=jarin@chromium.org,hpayer@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux64_msan_rel

Committed: https://crrev.com/cb19257a926a55209a6d6858ce26d51a0447ba71
Cr-Commit-Position: refs/heads/master@{#39511}
==========

[commit-bot: I haz the power, 2016-09-20 05:58:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-20 05:59:46]

Description was changed from

==========
[crankshaft] Protect against deopt loops from string length overflows.

Crankshaft just unconditionally deoptimizes the code when the length of
a string addition result would overflow. In order to protect against
deopt loops we insert a global protector cell.

We will use the same mechanism for inlining certain string additions
into TurboFan as well, and protecting against overflow (we will also
extend this to deal with String.prototype.concat and friends once we
get there).

BUG=v8:5404
R=jarin@chromium.org,hpayer@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux64_msan_rel

Committed: https://crrev.com/cb19257a926a55209a6d6858ce26d51a0447ba71
Cr-Commit-Position: refs/heads/master@{#39511}
==========

to

==========
[crankshaft] Protect against deopt loops from string length overflows.

Crankshaft just unconditionally deoptimizes the code when the length of
a string addition result would overflow. In order to protect against
deopt loops we insert a global protector cell.

We will use the same mechanism for inlining certain string additions
into TurboFan as well, and protecting against overflow (we will also
extend this to deal with String.prototype.concat and friends once we
get there).

BUG=v8:5404
R=jarin@chromium.org,hpayer@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux64_msan_rel

Committed: https://crrev.com/cb19257a926a55209a6d6858ce26d51a0447ba71
Committed: https://crrev.com/d86038db25064fb40fbce6fc3b2fb67831f9e7b1
Cr-Original-Commit-Position: refs/heads/master@{#39511}
Cr-Commit-Position: refs/heads/master@{#39525}
==========

[commit-bot: I haz the power, 2016-09-20 05:59:47]

Patchset 2 (id:??) landed as
https://crrev.com/d86038db25064fb40fbce6fc3b2fb67831f9e7b1
Cr-Commit-Position: refs/heads/master@{#39525}