Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Unified Diff: src/factory.cc

Issue 2348293002: [crankshaft] Protect against deopt loops from string length overflows. (Closed)
Patch Set: Fix MSAN Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/factory.h ('k') | src/heap/heap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/factory.cc
diff --git a/src/factory.cc b/src/factory.cc
index 1c31840a55c1077b583c67a4db3d62d3a438c7cd..589f36d46d4e5e835fe89188255c19bc8982decb 100644
--- a/src/factory.cc
+++ b/src/factory.cc
@@ -1214,6 +1214,13 @@ Handle<Object> Factory::NewError(Handle<JSFunction> constructor,
return maybe_error.ToHandleChecked();
}
+Handle<Object> Factory::NewInvalidStringLengthError() {
+ // Invalidate the "string length" protector.
+ if (isolate()->IsStringLengthOverflowIntact()) {
+ isolate()->InvalidateStringLengthOverflowProtector();
+ }
+ return NewRangeError(MessageTemplate::kInvalidStringLength);
+}
#define DEFINE_ERROR(NAME, name) \
Handle<Object> Factory::New##NAME(MessageTemplate::Template template_index, \
« no previous file with comments | « src/factory.h ('k') | src/heap/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698