Issue 2348223002: chrome_initial does not need //ui/gfx on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2348223002: chrome_initial does not need //ui/gfx on Windows. (Closed)

Created:
4 years, 3 months ago by grt (UTC plus 2)

Modified:
4 years, 3 months ago

Reviewers:
brucedawson, grt (UTC plus 2)

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

chrome_initial does not need //ui/gfx on Windows. chrome.exe appears to have grown by 150% when skia rolled in r411308. chrome.exe shouldn't need skia or gfx, so let's try not depending on them! BUG=647223 R=brucedawson@chromium.org Review-Url: https://codereview.chromium.org/2345503006 Cr-Commit-Position: refs/heads/master@{#418986} (cherry picked from commit 1504ef7199454f8096cf1ecdece90a8476aa4a31) TBR=grt@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/9d9efb8c742f159c782a6574be6299feb3cf403d

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

grt (UTC plus 2)

4 years, 3 months ago (2016-09-19 09:54:57 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9d9efb8c742f159c782a6574be6299feb3cf403d.