chrome_initial does not need //ui/gfx on Windows.

chrome_initial does not need //ui/gfx on Windows.

chrome.exe appears to have grown by 150% when skia rolled in r411308.
chrome.exe shouldn't need skia or gfx, so let's try not depending on
them!

BUG=647223
R=brucedawson@chromium.org

Committed: https://crrev.com/1504ef7199454f8096cf1ecdece90a8476aa4a31
Cr-Commit-Position: refs/heads/master@{#418986}

[grt (UTC plus 2), 2016-09-15 19:23:13]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 19:23:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2016-09-15 19:27:37]

In local testing, this prevents skia from being linked into chrome.exe. I wonder
if it actually works? :-)

[brucedawson, 2016-09-15 19:45:46]

On 2016/09/15 19:27:37, grt (UTC plus 2) wrote:
> In local testing, this prevents skia from being linked into chrome.exe. I
wonder
> if it actually works? :-)

I patched it in locally and saw no difference in the size of chrome.exe.
3,035,648 bytes, with these settings:

is_component_build = false
is_debug = false
target_cpu = "x86"
is_clang = false

[grt (UTC plus 2), 2016-09-15 19:49:00]

On 2016/09/15 19:45:46, brucedawson wrote:
> On 2016/09/15 19:27:37, grt (UTC plus 2) wrote:
> > In local testing, this prevents skia from being linked into chrome.exe. I
> wonder
> > if it actually works? :-)
> 
> I patched it in locally and saw no difference in the size of chrome.exe.
> 3,035,648 bytes, with these settings:
> 
> is_component_build = false
> is_debug = false
> target_cpu = "x86"
> is_clang = false

Are you tots sure? For me, the difference is 2,952,192 vs 921,088 bytes.

is_chrome_branded = true
is_component_build = false
is_debug = false
target_cpu = "x86"

[commit-bot: I haz the power, 2016-09-15 21:19:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:19:06]

Dry run: This issue passed the CQ dry run.

[grt (UTC plus 2), 2016-09-15 21:22:56]

Hi Bruce. Since this is green on the bots, what do you think of landing it to
see what happens? Please check the CQ box if you think it's worth it. On my
machine, it seems to resolve the pain. Thanks.

[brucedawson, 2016-09-15 21:26:00]

Thanks for the fix. lgtm. With your build settings I have confirmed your
results. I'm doing another build without is_chrome_branded to see if that really
affects the results, since that would indicate unwanted fragility. But, well
worth landing. I'll click the button.

Thanks for the fix!

[brucedawson, 2016-09-15 21:26:07]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:26:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 21:35:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-15 21:36:41]

Description was changed from

==========
chrome_initial does not need //ui/gfx on Windows.

chrome.exe appears to have grown by 150% when skia rolled in r411308.
chrome.exe shouldn't need skia or gfx, so let's try not depending on
them!

BUG=647223
R=brucedawson@chromium.org
==========

to

==========
chrome_initial does not need //ui/gfx on Windows.

chrome.exe appears to have grown by 150% when skia rolled in r411308.
chrome.exe shouldn't need skia or gfx, so let's try not depending on
them!

BUG=647223
R=brucedawson@chromium.org

Committed: https://crrev.com/1504ef7199454f8096cf1ecdece90a8476aa4a31
Cr-Commit-Position: refs/heads/master@{#418986}
==========

[commit-bot: I haz the power, 2016-09-15 21:36:42]

Patchset 1 (id:??) landed as
https://crrev.com/1504ef7199454f8096cf1ecdece90a8476aa4a31
Cr-Commit-Position: refs/heads/master@{#418986}