Evaluates arguments before throwing a NoSuchMethodError in constructor

runtime/vm/flow_graph_builder.h

Index: runtime/vm/flow_graph_builder.h
===================================================================
--- runtime/vm/flow_graph_builder.h	(revision 26748)
+++ runtime/vm/flow_graph_builder.h	(working copy)
@@ -359,7 +359,15 @@
   StaticCallInstr* BuildThrowNoSuchMethodError(intptr_t token_pos,
                                                const Class& function_class,
                                                const String& function_name,
+                                               ArgumentListNode* actuals,

[regis, 2013/08/28 21:10:54]

If we emulate the naming convention used by BuildStaticNoSuchMethodCall above,
'actuals' should be called 'function_arguments'.

[zra, 2013/08/28 22:47:00]

Done.

                                                int invocation_type);
+  StaticCallInstr* BuildThrowNoSuchMethodError(intptr_t token_pos,
+                                               const Class& function_class,
+                                               const String& function_name,
+                                               int invocation_type) {
+    return BuildThrowNoSuchMethodError(
+        token_pos, function_class, function_name, NULL, invocation_type);

[regis, 2013/08/28 21:10:54]

Overriding is not encouraged. Why not make it clear by forcing the caller to
pass NULL?

[zra, 2013/08/28 22:47:00]

Done.

+  }
 
   void BuildStaticSetter(StaticSetterNode* node, bool result_is_needed);
   Definition* BuildStoreStaticField(StoreStaticFieldNode* node,