Evaluates arguments before throwing a NoSuchMethodError in constructor

runtime/vm/flow_graph_builder.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_FLOW_GRAPH_BUILDER_H_
 #define VM_FLOW_GRAPH_BUILDER_H_
 
 #include "vm/allocation.h"
 #include "vm/ast.h"
 #include "vm/growable_array.h"
@@ skipping 341 matching lines @@
   StaticCallInstr* BuildStaticNoSuchMethodCall(
       const Class& target_class,
       AstNode* receiver,
       const String& method_name,
       ArgumentListNode* method_arguments,
       bool save_last_arg);
 
   StaticCallInstr* BuildThrowNoSuchMethodError(intptr_t token_pos,
                                                const Class& function_class,
                                                const String& function_name,
+                                               ArgumentListNode* actuals,

[regis, 2013/08/28 21:10:54]

If we emulate the naming convention used by BuildStaticNoSuchMethodCall above,
'actuals' should be called 'function_arguments'.

[zra, 2013/08/28 22:47:00]

Done.

                                                int invocation_type);
+  StaticCallInstr* BuildThrowNoSuchMethodError(intptr_t token_pos,
+                                               const Class& function_class,
+                                               const String& function_name,
+                                               int invocation_type) {
+    return BuildThrowNoSuchMethodError(
+        token_pos, function_class, function_name, NULL, invocation_type);

[regis, 2013/08/28 21:10:54]

Overriding is not encouraged. Why not make it clear by forcing the caller to
pass NULL?

[zra, 2013/08/28 22:47:00]

Done.

+  }
 
   void BuildStaticSetter(StaticSetterNode* node, bool result_is_needed);
   Definition* BuildStoreStaticField(StoreStaticFieldNode* node,
                                     bool result_is_needed);
 
   ClosureCallInstr* BuildClosureCall(ClosureCallNode* node);
 
   Value* BuildNullValue();
 
   // Returns true if the run-time type check can be eliminated.
@@ skipping 140 matching lines @@
   // Output parameters.
   GrowableArray<TargetEntryInstr**> true_successor_addresses_;
   GrowableArray<TargetEntryInstr**> false_successor_addresses_;
 
   intptr_t condition_token_pos_;
 };
 
 }  // namespace dart
 
 #endif  // VM_FLOW_GRAPH_BUILDER_H_